◐ Shell
reader mode source ↗
Skip to content

bpo-34663: Add support for POSIX_SPAWN_USEVFORK in posix_spawn when available#9271

Closed
pablogsal wants to merge 6 commits into
python:masterfrom
pablogsal:usevfork_posix_spawn
Closed

bpo-34663: Add support for POSIX_SPAWN_USEVFORK in posix_spawn when available#9271
pablogsal wants to merge 6 commits into
python:masterfrom
pablogsal:usevfork_posix_spawn

Conversation

@pablogsal

@pablogsal pablogsal commented Sep 13, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal requested a review from vstinner September 13, 2018 18:15
@bedevere-bot

bedevere-bot commented Sep 13, 2018

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@bedevere-bot bedevere-bot added and removed awaiting merge labels Sep 13, 2018
@pablogsal

pablogsal commented Sep 13, 2018

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Sep 13, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinner

vstinner commented Sep 13, 2018

Copy link
Copy Markdown
Member

Please also document the use_vfork parameter in Doc/library/os.html

@bedevere-bot

bedevere-bot commented Sep 13, 2018

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal pablogsal force-pushed the usevfork_posix_spawn branch 3 times, most recently from 71f1afa to 9c14de2 Compare September 13, 2018 21:38
@pablogsal

pablogsal commented Sep 14, 2018

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Sep 14, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner
vstinner approved these changes Sep 14, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@gpshead: Would you mind to double check this PR?

@benjaminp: Would you be interested to have a look as well? (the plan is then to experiment to use it in subprocess for performance.)

@pablogsal pablogsal closed this Sep 20, 2018
@pablogsal pablogsal deleted the usevfork_posix_spawn branch September 20, 2018 10:50
@pablogsal pablogsal restored the usevfork_posix_spawn branch January 9, 2019 18:30
@pablogsal pablogsal deleted the usevfork_posix_spawn branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @bedevere-bot @vstinner @the-knights-who-say-ni