◐ Shell
reader mode source ↗
Skip to content

test_threaded_import: Fix unittest.main spelling#93114

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
The-Compiler:fix-test-threaded-import
May 25, 2022
Merged

test_threaded_import: Fix unittest.main spelling#93114
serhiy-storchaka merged 1 commit into
python:mainfrom
The-Compiler:fix-test-threaded-import

Conversation

@The-Compiler

@The-Compiler The-Compiler commented May 23, 2022

Copy link
Copy Markdown
Contributor

Regressed in 40348ac (GH-28405, v3.11.0a1) - cc @serhiy-storchaka.

(Also regressed in Lib/test/test_importlib/test_locks.py, but there it was already fixed in 2b16a08 by @tiran)

I believe this is simple enough to not need an issue/news-entry, but let me know if you disagree!

(Found by running flake8 over Lib/ out of curiosity, see #93010 (comment))

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 23, 2022
serhiy-storchaka
serhiy-storchaka approved these changes May 23, 2022
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Good catch!

@serhiy-storchaka serhiy-storchaka merged commit 1971014 into python:main May 25, 2022
@miss-islington

miss-islington commented May 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @The-Compiler for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
@The-Compiler @miss-islington
test_threaded_import: Fix unittest.main spelling (pythonGH-93114) …
ed6ae41 
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 25, 2022
@bedevere-bot

bedevere-bot commented May 25, 2022

Copy link
Copy Markdown

GH-93208 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
@The-Compiler @miss-islington
test_threaded_import: Fix unittest.main spelling (pythonGH-93114) …
eec78d0 
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 25, 2022
@bedevere-bot

bedevere-bot commented May 25, 2022

Copy link
Copy Markdown

GH-93209 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request May 25, 2022
@miss-islington @The-Compiler
test_threaded_import: Fix unittest.main spelling (GH-93114) …
02d35fc 
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
miss-islington added a commit that referenced this pull request May 25, 2022
@miss-islington @The-Compiler
test_threaded_import: Fix unittest.main spelling (GH-93114) …
2ea3d3b 
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@The-Compiler @miss-islington @bedevere-bot @serhiy-storchaka