◐ Shell
reader mode source ↗
Skip to content

bpo-34632: Add the importlib.metadata module#9327

Closed
warsaw wants to merge 4 commits into
python:masterfrom
warsaw:issue34632
Closed

bpo-34632: Add the importlib.metadata module#9327
warsaw wants to merge 4 commits into
python:masterfrom
warsaw:issue34632

Conversation

@warsaw

@warsaw warsaw commented Sep 14, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@warsaw warsaw self-assigned this Sep 14, 2018
@brettcannon

brettcannon commented Sep 21, 2018

Copy link
Copy Markdown
Member

Review importlib.metadata

brettcannon
brettcannon requested changes Oct 20, 2018
View reviewed changes
12 hidden conversations Load more…
@bedevere-bot

bedevere-bot commented Oct 20, 2018

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@jaraco jaraco mentioned this pull request Feb 20, 2019
Open
@jaraco

jaraco commented Feb 20, 2019

Copy link
Copy Markdown
Member

Based on comments herein and other influences borne out by the public release of importlib_metadata, much has changed since this PR. We're going to want to restart this effort from the latest upstream codebase. There are only a couple of comments above that weren't addressed that will need to be addressed in a subsequent port.

@jaraco jaraco closed this Feb 20, 2019
@warsaw warsaw deleted the issue34632 branch March 14, 2019 00:12
@jaraco jaraco mentioned this pull request Mar 26, 2019
Merged
vuno-bmkim pushed a commit to vuno-bmkim/importlib_metadata that referenced this pull request Sep 16, 2019
@jaraco
Make two edits based on suggestions in python/cpython#9327.
5c9f2ed
This was referenced Oct 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco left review comments

@brettcannon brettcannon brettcannon requested changes

Assignees

@warsaw warsaw

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@warsaw @brettcannon @bedevere-bot @jaraco @the-knights-who-say-ni