◐ Shell
reader mode source ↗
Skip to content

gh-85299: Add note warning about entry point guard for asyncio example#93457

Merged
gvanrossum merged 5 commits into
python:mainfrom
slateny:s/85299
Oct 16, 2022
Merged

gh-85299: Add note warning about entry point guard for asyncio example#93457
gvanrossum merged 5 commits into
python:mainfrom
slateny:s/85299

Conversation

@slateny

@slateny slateny commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

@slateny slateny requested review from 1st1 and asvetlov as code owners June 3, 2022 09:33
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 3, 2022
@bedevere-bot

bedevere-bot commented Oct 13, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@gvanrossum

gvanrossum commented Oct 14, 2022

Copy link
Copy Markdown
Member

Okay, I am beginning to understand the issue. It's due to the process pool example. If I comment out this block of code from the example:

    # 3. Run in a custom process pool:
    with concurrent.futures.ProcessPoolExecutor() as pool:
        result = await loop.run_in_executor(
            pool, cpu_bound)
        print('custom process pool', result)

everything is fine. If I leave that in the run (on macOS) fails spectacularly with a RuntimeError that has many lines of traceback, then a multi-line error message, and then more traceback lines. Adding the __main__ guard makes this go away.

I presume that's one of the many reasons not to use ProcessPoolExecutor. :-(

I propose to rephrase the note to mention the platform and just link to https://docs.python.org/3/library/multiprocessing.html#the-spawn-and-forkserver-start-methods, not to the change note.

gvanrossum
gvanrossum approved these changes Oct 16, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks!

@gvanrossum gvanrossum merged commit 79fd6cc into python:main Oct 16, 2022
@miss-islington

miss-islington commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @slateny for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @slateny for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2022
@slateny @miss-islington
pythongh-85299: Add note warning about entry point guard for asyncio … …
09fe4f9 
…example (pythonGH-93457)

(cherry picked from commit 79fd6cc)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Oct 16, 2022

Copy link
Copy Markdown

GH-98334 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 16, 2022
@gvanrossum

gvanrossum commented Oct 16, 2022

Copy link
Copy Markdown
Member

Let’s see if we can backport this.

@bedevere-bot

bedevere-bot commented Oct 16, 2022

Copy link
Copy Markdown

GH-98335 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2022
@slateny @miss-islington
pythongh-85299: Add note warning about entry point guard for asyncio … …
8a7bff2 
…example (pythonGH-93457)

(cherry picked from commit 79fd6cc)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 16, 2022
@miss-islington @slateny
gh-85299: Add note warning about entry point guard for asyncio example ( …
2630738 
GH-93457)

(cherry picked from commit 79fd6cc)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 16, 2022
@miss-islington @slateny
gh-85299: Add note warning about entry point guard for asyncio example ( …
e26c526 
GH-93457)

(cherry picked from commit 79fd6cc)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@slateny slateny deleted the s/85299 branch October 16, 2022 20:40
carljm added a commit to carljm/cpython that referenced this pull request Oct 17, 2022
@carljm
Merge branch 'main' into typewatch …
cdbe93b 
* main: (31 commits)
  pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345)
  pythongh-95914: Add What's New item describing PEP 670 changes (python#98315)
  Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358)
  pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316)
  pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333)
  pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001)
  pythongh-97669: Create Tools/build/ directory (python#97963)
  pythongh-95534: Improve gzip reading speed by 10% (python#97664)
  pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344)
  pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336)
  pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929)
  pythongh-85525: Remove extra row in doc (python#98337)
  pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457)
  pythongh-97527: IDLE - fix buggy macosx patch (python#98313)
  pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319)
  pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158)
  pythonGH-94597: Deprecate child watcher getters and setters (python#98215)
  pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255)
  Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294)
  [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290)
  ...
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @slateny @pablogsal
gh-85299: Add note warning about entry point guard for asyncio example ( …
a2820a0 
GH-93457)

(cherry picked from commit 79fd6cc)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@slateny @bedevere-bot @gvanrossum @miss-islington @CAM-Gerlach @kumaraditya303