◐ Shell
reader mode source ↗
Skip to content

[3.11] GH-93516: Backport GH-93769: Store offset of first traceable instruction in code object#93818

Closed
markshannon wants to merge 1 commit into
python:3.11from
faster-cpython:backport-93516
Closed

[3.11] GH-93516: Backport GH-93769: Store offset of first traceable instruction in code object#93818
markshannon wants to merge 1 commit into
python:3.11from
faster-cpython:backport-93516

Conversation

@markshannon

@markshannon markshannon commented Jun 14, 2022

Copy link
Copy Markdown
Member

No description provided.

@markshannon markshannon requested a review from pablogsal June 14, 2022 16:37
@markshannon

markshannon commented Jun 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

The ABI check fails, due to adding the _co_firsttraceable field.
I've added it near the end, so that code that accesses fields other that co_extra and co_code_adaptive will not be effected.

@markshannon markshannon mentioned this pull request Jun 14, 2022
Open
@nedbat

nedbat commented Jun 15, 2022

Copy link
Copy Markdown
Member

I tried this compared to 3.11.0b3, and this code is slightly slower?

cov proj python3.11 gh93818 93818 vs 3.11
6.4.1 bug1339.py 0.846 s 0.856 s 101.20%
6.4.1 bm_sudoku.py 55.436 s 57.561 s 103.83%
6.4.1 bm_spectral_norm.py 66.488 s 68.803 s 103.48%

@markshannon

markshannon commented Jun 15, 2022

Copy link
Copy Markdown
Member Author

Odd.
I wouldn't expect this to have much effect compared to removing the overhead of line number lookup, or caching the result of PyCode_GetCode(), but I would expect it to be positive.

Let's remeasure after those are merged.

@markshannon markshannon mentioned this pull request Jun 17, 2022
Merged
@markshannon
pythonGH-93516: Speedup line number checks when tracing. (pythonGH-93763 …
0bd6735 
)

* Use a lookup table to reduce overhead of getting line numbers during tracing.
@pablogsal

pablogsal commented Jun 21, 2022

Copy link
Copy Markdown
Member

I'm regenerating the ABI in this PR

@pablogsal

pablogsal commented Jun 21, 2022

Copy link
Copy Markdown
Member

@markshannon I cannot push to the remote repo, could you please ensure the "allow pushes from maintainers checkbox is activated on the right column"?

@markshannon markshannon mentioned this pull request Jun 22, 2022
Merged
@markshannon

markshannon commented Jun 22, 2022

Copy link
Copy Markdown
Member Author

Closing this until I've had time to investigate the slowdown once #94127 is merged.

@markshannon markshannon deleted the backport-93516 branch September 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon @nedbat @pablogsal @bedevere-bot