◐ Shell
reader mode source ↗
Skip to content

gh-93939: Build most shared extensions without setup.py#93940

Closed
tiran wants to merge 6 commits into
python:mainfrom
tiran:gh-93939-setup-stdlib
Closed

gh-93939: Build most shared extensions without setup.py#93940
tiran wants to merge 6 commits into
python:mainfrom
tiran:gh-93939-setup-stdlib

Conversation

@tiran

@tiran tiran commented Jun 17, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@tiran

tiran commented Jun 17, 2022

Copy link
Copy Markdown
Member Author

macOS builder fails with sed: 13: @sed.in.11268: extra characters at the end of h command in configure step. Could somebody with a Mac please debug the problem?

@tiran tiran force-pushed the gh-93939-setup-stdlib branch from 7cb1c1f to e45af20 Compare June 26, 2022 08:40
@tiran tiran force-pushed the gh-93939-setup-stdlib branch 6 times, most recently from 27867a5 to ea81ed8 Compare June 28, 2022 20:29
@ned-deily

ned-deily commented Jun 28, 2022

Copy link
Copy Markdown
Member

macOS builder fails with sed: 13: @sed.in.11268: extra characters at the end of h command in configure step. Could somebody with a Mac please debug the problem?

macOS uses a BSD-based version of sed and apparently an old version at that. There are a number of documented differences among the various versions and I think you are running into one by trying to do the multi-line append here:

		echo "/Definitions added by makesetup/a$NL$NL$DEFS" >>$sedf
		cat $sedf

Searching the web, there are various ways suggested to do this in a manner that will work with all versions. One simple way that seemed to work with both the macOS and GNU versions is to write the contents of $DEFS to another temp file and then use the sed r command instead of a to insert them.

@tiran tiran mentioned this pull request Jun 29, 2022
Closed
@tiran

tiran commented Jun 29, 2022

Copy link
Copy Markdown
Member Author

Thanks @ned-deily! sed r command works like a charm.

@tiran tiran force-pushed the gh-93939-setup-stdlib branch from 60d4b36 to 4af2830 Compare June 29, 2022 08:14
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@bedevere-bot

bedevere-bot commented Jun 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 4af2830c1cdfdc4a3a0fc0e5a8f491fa09301b14 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@tiran tiran force-pushed the gh-93939-setup-stdlib branch from 4af2830 to 6502e8c Compare June 29, 2022 10:11
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@bedevere-bot

bedevere-bot commented Jun 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 6502e8c76540e19b489e8aab31801d88cf1986ed 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@tiran tiran force-pushed the gh-93939-setup-stdlib branch from 6502e8c to e23a5dd Compare June 29, 2022 13:47
@tiran tiran mentioned this pull request Jul 1, 2022
Merged
@tiran

tiran commented Jul 5, 2022

Copy link
Copy Markdown
Member Author

The PR was an experiment. I'll open a proper PR when everything is in place.

@tiran tiran closed this Jul 5, 2022
miss-islington pushed a commit that referenced this pull request Jul 14, 2022
@tiran
gh-93939: Build C extensions without setup.py (GH-94474) …
81dca70 
Combines GH-93940, GH-94452, and GH-94433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran @ned-deily @bedevere-bot @arhadthedev