◐ Shell
reader mode source ↗
Skip to content

Document 3.13, 3.14, 4.0 and future removals#93986

Closed
hugovk wants to merge 8 commits into
python:mainfrom
hugovk:document-pending-removals
Closed

Document 3.13, 3.14, 4.0 and future removals#93986
hugovk wants to merge 8 commits into
python:mainfrom
hugovk:document-pending-removals

Conversation

@hugovk

@hugovk hugovk commented Jun 18, 2022

Copy link
Copy Markdown
Member

Follow on from #92308.

This lists in the What's New page some more deprecations pending removal in:

@warsaw

warsaw commented Jun 18, 2022

Copy link
Copy Markdown
Member

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen? Like, maybe a JSON file or some such where the deprecations are recorded (or a script to parse the docs or code). Then, when the new version is created at main, the automation would open some release blockers on those deprecations. What do you think?

@arhadthedev

arhadthedev commented Jun 18, 2022

Copy link
Copy Markdown
Member

@warsaw Probably, grepping docs for .. deprecated-removed:: and headers for Py_DEPRECATED would be better than maintaining another list file.

Edit: for \.\. deprecated-removed:: [^ ]+ (\d+).(\d+) and Py_DEPRECATED\((\d+).(\d+)\).

@hugovk

hugovk commented Jun 19, 2022

Copy link
Copy Markdown
Member Author

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

Yes, using the new warnings._deprecated method will make it clear with RuntimeErrors after the relevant alpha: https://discuss.python.org/t/introducing-warnings-deprecated/14856

@ezio-melotti

Copy link
Copy Markdown
Member

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

See also:

@ezio-melotti ezio-melotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I left a comment and a couple of minor suggestions -- feel free to disregard them if you think the current version is better.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@CAM-Gerlach

Copy link
Copy Markdown
Member

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

You could also fire a Sphinx warning in the else branch here in the directive (with a check for whether its an alpha, and perhaps an :option: to disable it for special cases), just like warnings._deprecated does.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@CAM-Gerlach CAM-Gerlach mentioned this pull request Aug 12, 2022
33 tasks
@hugovk

hugovk commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Will try again in a new PR :)

@hugovk hugovk closed this Aug 16, 2023
@hugovk hugovk deleted the document-pending-removals branch August 16, 2023 19:19
@hugovk

hugovk commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Please see PR #108055 instead 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants