◐ Shell
reader mode source ↗
Skip to content

gh-93896: allow enabling asyncio.Runner calls to asyncio.set_event_loop independantly to loop_factory#94058

Closed
graingert wants to merge 13 commits into
python:mainfrom
graingert:restore-set-event-loop-policy-to-asyncio-run
Closed

gh-93896: allow enabling asyncio.Runner calls to asyncio.set_event_loop independantly to loop_factory#94058
graingert wants to merge 13 commits into
python:mainfrom
graingert:restore-set-event-loop-policy-to-asyncio-run

Conversation

@graingert

@graingert graingert commented Jun 21, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@graingert graingert changed the title restore the set_event_loop calls to asyncio.run Jun 21, 2022
@graingert graingert changed the title #93896 restore the set_event_loop calls to asyncio.run Jun 21, 2022
@graingert graingert changed the title #gh-93896 restore the set_event_loop calls to asyncio.run Jun 21, 2022
@graingert graingert changed the title #gh-93896: restore the set_event_loop calls to asyncio.run Jun 21, 2022
@graingert graingert force-pushed the restore-set-event-loop-policy-to-asyncio-run branch from f21f808 to abbd6b4 Compare June 22, 2022 12:52
@graingert graingert marked this pull request as ready for review June 22, 2022 13:29
@graingert graingert requested review from 1st1 and asvetlov as code owners June 22, 2022 13:29
@graingert graingert mentioned this pull request Jun 22, 2022
Closed
@encukou encukou requested a review from pablogsal July 4, 2022 17:19
@graingert graingert changed the title gh-93896: restore the set_event_loop calls to asyncio.run Jul 6, 2022
@graingert

graingert commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

I've merged the changes from #94593 so I'm now proposing this as a feature change instead of a bug fix

@graingert

graingert commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

I'll close this PR for now. It might make sense to re-introduce the set_policy_loop kwarg for 3.12 if the policy system is deprecated

@graingert graingert closed this Jul 6, 2022
@graingert graingert deleted the restore-set-event-loop-policy-to-asyncio-run branch July 6, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@pablogsal pablogsal

+1 more reviewer

@Bluenix2 Bluenix2 Bluenix2 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IsolatedAsyncioTestCase and asyncio.run no-longer call asyncio.set_event_loop

4 participants

@graingert @Bluenix2 @kumaraditya303 @bedevere-bot