◐ Shell
reader mode source ↗
Skip to content

[3.7] Revert "[3.7] bpo-34589: Add -X coerce_c_locale option; C locale coercion off by default (GH-9379)"#9416

Merged
vstinner merged 1 commit into
python:3.7from
vstinner:revert_coerce
Sep 19, 2018
Merged

[3.7] Revert "[3.7] bpo-34589: Add -X coerce_c_locale option; C locale coercion off by default (GH-9379)"#9416
vstinner merged 1 commit into
python:3.7from
vstinner:revert_coerce

Conversation

@vstinner

@vstinner vstinner commented Sep 19, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@vstinner vstinner requested a review from ncoghlan September 19, 2018 11:11
ncoghlan
ncoghlan approved these changes Sep 19, 2018
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks. I think leaving the 3.7 branch alone is the best way to go here, and then we can wrangle at our leisure on how to get the locale coercion implementation back to its as-designed-and-initially-implemented architecture for 3.8+

@vstinner

vstinner commented Sep 19, 2018

Copy link
Copy Markdown
Member Author

Oh wow, I have been bitten by two random CI bugs from the outer space:

  • Travis CI failed because of the random test_socket failure: https://bugs.python.org/issue33937
  • test_subprocess hangs on Windows!? "running: test_subprocess (53 min 15 sec)"

I restarted the Travis CI job.

@vstinner

vstinner commented Sep 19, 2018

Copy link
Copy Markdown
Member Author

Oh, on AppVeyor, test_functools failed a timeout after 20 min on test_parallel_meta_path().

Linux-PR CI failed to build its environment:

2018-09-19T11:14:10.5896975Z E: Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)

CIs are grumpy today.

@vstinner vstinner closed this Sep 19, 2018
@vstinner vstinner reopened this Sep 19, 2018
@vstinner

vstinner commented Sep 19, 2018

Copy link
Copy Markdown
Member Author

Close/reopen to retrigger AppVeyor job.

@vstinner vstinner merged commit 95cc3ee into python:3.7 Sep 19, 2018
@vstinner vstinner deleted the revert_coerce branch September 19, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @ncoghlan @the-knights-who-say-ni @bedevere-bot