◐ Shell
reader mode source ↗
Skip to content

Add ABI dump to .gitignore#94166

Closed
encukou wants to merge 1 commit into
python:mainfrom
encukou:abidump-script
Closed

Add ABI dump to .gitignore#94166
encukou wants to merge 1 commit into
python:mainfrom
encukou:abidump-script

Conversation

@encukou

@encukou encukou commented Jun 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

The ABI is only checked in maintenance branches, but it is sometimes useful to generate it for main.

  • The resulting file should be ignored in main.
  • The file should be created if it doesn't exist.

If this goes in, some “make maintenance branch” RM checklist/script will need a “remove Doc/data/python*.abi from .gitignore” entry.

@pablogsal, this could be combined with #94135

@encukou
Add ABI dump to .gitignore …
9a2466d 
The ABI is only checked in maintenance branches, but it is sometimes
useful to generate it for main.

- The resulting file should be ignored in main.
- The file should be created if it doesn't exist.
@encukou encukou requested a review from pablogsal June 23, 2022 11:35
@arhadthedev

arhadthedev commented Jun 23, 2022

Copy link
Copy Markdown
Member

remove Doc/data/python*.abi from .gitignore

Calling git add with --force allows to keep gitignore unmodified:

-f, --force
Allow adding otherwise ignored files.

@encukou

encukou commented Jun 23, 2022

Copy link
Copy Markdown
Member Author

Yes, but AFAIK there are then warnings when you update a file that's ignored but tracked anyway.
The maintenance branches need some changes anyway – adding the CI check, at least – so I asume it's not a big burden to update .gitignore.

@pablogsal

pablogsal commented Jun 23, 2022

Copy link
Copy Markdown
Member

@pablogsal, this could be combined with #94135

@encukou do you want me to add this change to that PR?

@encukou

encukou commented Jun 23, 2022

Copy link
Copy Markdown
Member Author

Go ahead!

@encukou encukou closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

awaiting core review skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou @arhadthedev @pablogsal @bedevere-bot