gh-90005: Port readline and curses to PY_STDLIB_MOD (GH-94452)#94452
Conversation
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit 33d9e296124d7daeef89fca957bdab51e1e1d11b 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
8a61447 to
dd59373
Compare
June 30, 2022 19:40
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit dd5937322e181781c03213621eddb0fb88527c48 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
erlend-aasland
left a comment
There was a problem hiding this comment.
Great work! I left some comments.
Sorry, something went wrong.
dd59373 to
a72b632
Compare
July 1, 2022 20:08
erlend-aasland
left a comment
There was a problem hiding this comment.
These suggestions should work. You should be able to apply them as a batch.
Sorry, something went wrong.
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
|
@erlend-aasland I have refactored the code. There is a bit of repetition but IMHO it's ok for a few lookups. We could add our own variant of |
Sorry, something went wrong.
|
I have merged the PR. It works on all tested platforms. We can review and address the general issue with |
Sorry, something went wrong.
|
Hi, I think I found an issue. On Solaris, even a simple code like: char readline ();
int main (void) {
return readline ();
}needs to be linked with both Is there something I am missing or something I can try? |
Sorry, something went wrong.
|
Ah, it's indeed fixed. I am sorry, I thought I am looking into latest main but it was 12 days old (when this was pushed). Thanks for help! |
Sorry, something went wrong.
edited by bedevere-bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.