◐ Shell
reader mode source ↗
Skip to content

[3.11] GH-93252: Fix error handling for failed Python calls (GH-94693)#94707

Closed
tiran wants to merge 2 commits into
python:3.11from
tiran:backport-8a285df-3.11
Closed

[3.11] GH-93252: Fix error handling for failed Python calls (GH-94693)#94707
tiran wants to merge 2 commits into
python:3.11from
tiran:backport-8a285df-3.11

Conversation

@tiran

@tiran tiran commented Jul 9, 2022

Copy link
Copy Markdown
Member

@tiran tiran requested a review from markshannon as a code owner July 9, 2022 11:33
@bedevere-bot bedevere-bot added type-crash A hard crash of the interpreter, possibly with a core dump awaiting core review labels Jul 9, 2022
@tiran tiran requested a review from brandtbucher July 9, 2022 11:33
@tiran

tiran commented Jul 9, 2022

Copy link
Copy Markdown
Member Author

I have removed the failing assert. 3.11 does not have co_framesize. GH-93908 was not backported to 3.11.

@kumaraditya303

Copy link
Copy Markdown
Contributor

I have removed the failing assert. 3.11 does not have co_framesize. GH-93908 was not backported to 3.11.

Looks like we both created backport at the same time. #94708 has correct assert for 3.11.

@tiran

tiran commented Jul 9, 2022

Copy link
Copy Markdown
Member Author

Let's use your backport.

@tiran tiran closed this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants