◐ Shell
reader mode source ↗
Skip to content

gh-94801: Use custom flags to check for headers and libs#94802

Merged
tiran merged 2 commits into
python:mainfrom
tiran:gh-94801-cflags
Jul 15, 2022
Merged

gh-94801: Use custom flags to check for headers and libs#94802
tiran merged 2 commits into
python:mainfrom
tiran:gh-94801-cflags

Conversation

@tiran

@tiran tiran commented Jul 13, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

@tiran tiran added the needs backport to 3.11 only security fixes label Jul 13, 2022
@tiran tiran requested a review from erlend-aasland July 13, 2022 08:14
@tiran

tiran commented Jul 13, 2022

Copy link
Copy Markdown
Member Author

I addressed most places. The code now correctly triggers Emscripten's embuilder to download and install ports.

@tiran tiran marked this pull request as ready for review July 13, 2022 21:30
@tiran tiran force-pushed the gh-94801-cflags branch from 6e49f8e to 7bb04f3 Compare July 14, 2022 08:08
@bedevere-bot

bedevere-bot commented Jul 14, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 7bb04f3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 14, 2022
erlend-aasland
erlend-aasland approved these changes Jul 14, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Nice! LGTM.

@tiran tiran added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jul 15, 2022
@bedevere-bot

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

1 similar comment
@bedevere-bot

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 15, 2022
@tiran tiran merged commit 944ff8c into python:main Jul 15, 2022
@miss-islington

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tiran tiran deleted the gh-94801-cflags branch July 15, 2022 12:48
@miss-islington

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 944ff8c57c9e8ff5a5bd18925070ddb1504490ab 3.11

tiran added a commit to tiran/cpython that referenced this pull request Jul 15, 2022
@tiran
[3.11] pythongh-94801: Use custom flags to check for headers and libs (… …
96e6bec 
…pythonGH-94802).

(cherry picked from commit 944ff8c)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2022
@bedevere-bot

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

GH-94881 is a backport of this pull request to the 3.11 branch.

tiran added a commit that referenced this pull request Jul 18, 2022
@tiran
[3.11] gh-94801: Use custom flags to check for headers and libs (GH-9… …
30412d9 
…4802) (GH-94881)

Co-authored-by: Christian Heimes <christian@python.org>
@tiran tiran mentioned this pull request Jul 18, 2022
Merged
@zanieb zanieb mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@tiran tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran @bedevere-bot @miss-islington @erlend-aasland