◐ Shell
reader mode source ↗
Skip to content

gh-72889: remove redundant mock.Mock()._is_coroutine = False workarounds#94926

Merged
gvanrossum merged 2 commits into
python:mainfrom
graingert:remove-redudant-mock-is-coroutine-workarounds
Jul 17, 2022
Merged

gh-72889: remove redundant mock.Mock()._is_coroutine = False workarounds#94926
gvanrossum merged 2 commits into
python:mainfrom
graingert:remove-redudant-mock-is-coroutine-workarounds

Conversation

@graingert

@graingert graingert commented Jul 17, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@graingert graingert requested review from 1st1 and asvetlov as code owners July 17, 2022 13:56
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jul 17, 2022
@graingert

graingert commented Jul 17, 2022

Copy link
Copy Markdown
Contributor Author

I don't think this needs a news entry

@gvanrossum gvanrossum added topic-asyncio skip news only security fixes labels Jul 17, 2022
gvanrossum
gvanrossum approved these changes Jul 17, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Since this just changes tests and the tests pass, I think this is okay.

@gvanrossum gvanrossum merged commit 07aeb74 into python:main Jul 17, 2022
@miss-islington

miss-islington commented Jul 17, 2022

Copy link
Copy Markdown
Contributor

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 17, 2022

Copy link
Copy Markdown

GH-94934 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 17, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2022
@graingert @miss-islington
pythongh-72889: Remove redundant mock.Mock()._is_coroutine = False wo… …
ed2722b 
…rkarounds (pythonGH-94926)

(cherry picked from commit 07aeb74)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@graingert graingert deleted the remove-redudant-mock-is-coroutine-workarounds branch July 17, 2022 17:23
miss-islington added a commit that referenced this pull request Jul 17, 2022
@miss-islington @graingert
gh-72889: Remove redundant mock.Mock()._is_coroutine = False workarou… …
8d0249e 
…nds (GH-94926)

(cherry picked from commit 07aeb74)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@mdboom mdboom mentioned this pull request Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@graingert @miss-islington @bedevere-bot @gvanrossum