◐ Shell
reader mode source ↗
Skip to content

[3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation#95061

Closed
erlend-aasland wants to merge 3 commits into
python:3.11from
erlend-aasland:3.11-sqlite-test-move-news
Closed

[3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation#95061
erlend-aasland wants to merge 3 commits into
python:3.11from
erlend-aasland:3.11-sqlite-test-move-news

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 20, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jul 20, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jul 20, 2022
Closed
@erlend-aasland erlend-aasland changed the title gh-54781: Add NEWS entry for sqlite3 test relocation Jul 20, 2022
@zware

zware commented Jul 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

The original PR GH-29304 had a NEWS entry now enshrined in Misc/NEWS.d/3.11.0a2.rst. See https://docs.python.org/3.11/whatsnew/changelog.html#id67 (though it does look like it was put in Library rather than Tests).

@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

The original PR GH-29304 had a NEWS entry now enshrined in Misc/NEWS.d/3.11.0a2.rst. See https://docs.python.org/3.11/whatsnew/changelog.html#id67 (though it does look like it was put in Library rather than Tests).

Right; what a mess I'm making here :) Sorry for all the noise. I'll blame the heat 🥵 Let's move it to the Tests category then; that seems like a better fit for that changelog item

@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

PTAL; moved and improved.

@erlend-aasland erlend-aasland changed the title [3.11] gh-54781: Add NEWS entry for sqlite3 test relocation Jul 20, 2022
zware
zware reviewed Jul 20, 2022
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, but should be done on main and backported (this NEWS file also exists on main).

@erlend-aasland

erlend-aasland commented Jul 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Of course; thanks for the heads-up. See:

@erlend-aasland erlend-aasland deleted the 3.11-sqlite-test-move-news branch July 20, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware left review comments

@terryjreedy terryjreedy

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland @zware @bedevere-bot