gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails#95264
gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails#95264serhiy-storchaka merged 5 commits into
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
7c6e493 to
b9307e9
Compare
July 26, 2022 06:49
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
b9307e9 to
8210ab3
Compare
July 26, 2022 06:52
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
9a20c80 to
9813348
Compare
July 26, 2022 07:13
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM. Thanks, Noam!
Sorry, something went wrong.
|
The only remaining issue, is that I'd like a NEWS entry that covers both this PR and Serhiy's PR. I don't think fixing this qualifies for skip news. Serhiy? |
Sorry, something went wrong.
|
At first I thought that these are rather theoretical bugs that do not manifest themselves in the real world, or the effect of which is insignificant. Later I realized that it is possible that these bugs can lead to a crash if |
Sorry, something went wrong.
|
Ok, I'm fine with that. Let's land this :) |
Sorry, something went wrong.
|
Thanks @noamcohen97 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
|
Sorry @noamcohen97 and @serhiy-storchaka, I had trouble checking out the |
Sorry, something went wrong.
…og fails (pythonGH-95264) (cherry picked from commit b1f648e) Co-authored-by: Noam Cohen <noam@noam.me>
|
Thanks @noamcohen97 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
…og fails (pythonGH-95264) (cherry picked from commit b1f648e) Co-authored-by: Noam Cohen <noam@noam.me>
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit b1f648e. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/58/builds/2801 Summary of the results of the build (if available): == Tests result: ENV CHANGED == 424 tests OK. 10 slowest tests:
1 test altered the execution environment: 11 tests skipped: Total duration: 40 min 57 sec Click to see traceback logsTracebackTests.test_unencodable_filename) ... ok
TracebackTests.test_nonexistent_module) ... ok
TracebackTests.test_broken_submodule) ... ok
TracebackTests.test_broken_from) ... ok
TracebackTests.test_exec_failure_nested) ... ok
TracebackTests.test_import_bug) ... ok
TracebackTests.test_nonexistent_module_nested) ... ok
TracebackTests.test_exec_failure) ... ok
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 1036, in _bootstrap_inner
self.run()
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 973, in run
self._target(*self._args, **self._kwargs)
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_import/__init__.py", line 471, in run
sys.settrace(None)
RuntimeError: Cannot install a trace function while another trace function is being installed
k
TracebackTests.test_broken_parent_from) ... ok
TracebackTests.test_broken_parent) ... ok
TracebackTests.test_syntax_error) ... ok
|
Sorry, something went wrong.
|
The failure in |
Sorry, something went wrong.
edited by bedevere-bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.