gh-93649: Split heaptype tests from _testcapimodule.c #95386
Conversation
The type this function would create is available as
_testcapi.HeapCTypeWithNegativeDict
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x SLES 3.x has failed when building commit 664e96a. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/540/builds/3379 Summary of the results of the build (if available): == Tests result: ENV CHANGED == 421 tests OK. 10 slowest tests:
1 test altered the execution environment: 14 tests skipped: Total duration: 6 min 27 sec Click to see traceback logsTracebackTests.test_broken_from) ... ok
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/threading.py", line 1036, in _bootstrap_inner
self.run()
File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/threading.py", line 973, in run
self._target(*self._args, **self._kwargs)
File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_import/__init__.py", line 471, in run
sys.settrace(None)
RuntimeError: Cannot install a trace function while another trace function is being installed
k
TracebackTests.test_unencodable_filename) ... ok
TracebackTests.test_broken_parent) ... ok
TracebackTests.test_nonexistent_module) ... ok
TracebackTests.test_syntax_error) ... ok
TracebackTests.test_broken_parent_from) ... ok
TracebackTests.test_exec_failure) ... ok
TracebackTests.test_import_bug) ... ok
TracebackTests.test_nonexistent_module_nested) ... ok
TracebackTests.test_exec_failure_nested) ... ok
TracebackTests.test_broken_submodule) ... ok
|
Sorry, something went wrong.
|
That failure looks unrelated. |
Sorry, something went wrong.
|
The buildbot's next job passed: https://buildbot.python.org/all/#/builders/540/builds/3380 |
Sorry, something went wrong.
|
@encukou, it seems that this PR introduced two unused vars: cpython/Modules/_testcapi/heaptype.c Lines 279 to 280 in 7da4937 I'm seeing warnings about it in https://github.com/python/cpython/pull/95874/files: |
Sorry, something went wrong.
|
Thanks for the catch! The warnings will be fixed in #95992 |
Sorry, something went wrong.

I'll need to add a test related to heap types, so I'm splitting these out before that to make the test module more manageable.