◐ Shell
reader mode source ↗
Skip to content

gh-94808: Coverage: Test uppercase string literal prefixes#95925

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
mdboom:coverage-upper-case-literal-prefixes
Sep 24, 2022
Merged

gh-94808: Coverage: Test uppercase string literal prefixes#95925
serhiy-storchaka merged 3 commits into
python:mainfrom
mdboom:coverage-upper-case-literal-prefixes

Conversation

@mdboom

@mdboom mdboom commented Aug 12, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 12, 2022
@mdboom mdboom mentioned this pull request Aug 12, 2022
Open
@iritkatriel

iritkatriel commented Sep 7, 2022

Copy link
Copy Markdown
Member

IIUC this is covering the uppercase cases here: http://droettboom.com/cpython-coverage/llvm-coverage/coverage/home/mdboom/Work/builds/cpython/Parser/string_parser.c.html#L183

@mdboom mdboom requested a review from iritkatriel September 22, 2022 14:05
@serhiy-storchaka serhiy-storchaka merged commit f00383e into python:main Sep 24, 2022
@miss-islington

miss-islington commented Sep 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 24, 2022

Copy link
Copy Markdown

GH-97518 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2022
@mdboom @miss-islington
pythongh-94808: Coverage: Test uppercase string literal prefixes (pyt… …
cda3a30 
…honGH-95925)

(cherry picked from commit f00383e)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
miss-islington added a commit that referenced this pull request Sep 25, 2022
@miss-islington @mdboom
gh-94808: Coverage: Test uppercase string literal prefixes (GH-95925) …
6daff06 
(cherry picked from commit f00383e)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.10 only security fixes label Sep 25, 2022
@miss-islington

miss-islington commented Sep 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 25, 2022
@bedevere-bot

bedevere-bot commented Sep 25, 2022

Copy link
Copy Markdown

GH-97537 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2022
@mdboom @miss-islington
pythongh-94808: Coverage: Test uppercase string literal prefixes (pyt… …
567fea8 
…honGH-95925)

(cherry picked from commit f00383e)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
miss-islington added a commit that referenced this pull request Sep 25, 2022
@miss-islington @mdboom
gh-94808: Coverage: Test uppercase string literal prefixes (GH-95925) …
00713a8 
(cherry picked from commit f00383e)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@mdboom mdboom deleted the coverage-upper-case-literal-prefixes branch December 22, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mdboom @iritkatriel @miss-islington @bedevere-bot @serhiy-storchaka