◐ Shell
reader mode source ↗
Skip to content

gh-95914: Add paragraph about PEP 654 in main body of 'What's New in 3.11'#95937

Merged
iritkatriel merged 8 commits into
python:mainfrom
iritkatriel:whatsnew
Aug 13, 2022
Merged

gh-95914: Add paragraph about PEP 654 in main body of 'What's New in 3.11'#95937
iritkatriel merged 8 commits into
python:mainfrom
iritkatriel:whatsnew

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 12, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels Aug 12, 2022
@gvanrossum gvanrossum changed the title gh-95914: add paragraph about pep 654 in main body of 'what's new in 3.11' Aug 12, 2022
@gvanrossum gvanrossum changed the title gh-95914: Add paragraph about pep 654 in main body of 'what's new in 3.11' Aug 12, 2022
gvanrossum
gvanrossum approved these changes Aug 12, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

If you can add a link to except* in the docs, fine. Otherwise, fine too.

@CAM-Gerlach CAM-Gerlach mentioned this pull request Aug 12, 2022
Closed
5 tasks
@CAM-Gerlach CAM-Gerlach added needs backport to 3.10 only security fixes 3.10 only security fixes needs backport to 3.11 only security fixes 3.11 only security fixes and removed needs backport to 3.10 only security fixes 3.10 only security fixes labels Aug 13, 2022
CAM-Gerlach
CAM-Gerlach requested changes Aug 13, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks, @iritkatriel . A few relatively modest comments, mostly as applyable suggestions.

iritkatriel and others added 7 commits August 13, 2022 12:18
@iritkatriel @CAM-Gerlach
whitespace …
6953eba 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@iritkatriel @CAM-Gerlach
heading …
87d77c4 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@iritkatriel @CAM-Gerlach
whitespace …
e18ee3c 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@iritkatriel @CAM-Gerlach
:keyword: …
4b13c09 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@iritkatriel
revert PEP-678 changes. Update titles
dd28613
@iritkatriel
whitespace
c64a047
@iritkatriel
whitespace
602fdc9
@iritkatriel iritkatriel merged commit 1402d2c into python:main Aug 13, 2022
@miss-islington

miss-islington commented Aug 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@iritkatriel iritkatriel deleted the whatsnew branch August 13, 2022 11:49
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2022
@iritkatriel @miss-islington
pythongh-95914: Add paragraph about PEP 654 in main body of 'What's N… …
0fc91f3 
…ew in 3.11' (pythonGH-95937)

(cherry picked from commit 1402d2c)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Aug 13, 2022

Copy link
Copy Markdown

GH-95954 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 13, 2022
@CAM-Gerlach

CAM-Gerlach commented Aug 14, 2022

Copy link
Copy Markdown
Member

A quick followup about the except* keyword—based on some testing by @ezio-melotti and myself, the index entry was a red herring; what actually happens with the :keyword: role is that it applies semantics and styling (i.e. literal, typically) but it just links to normal ref target labels, rather than ones created by a special directives, which the Sphinx docs also confirm. I'll open a separate PR to move the relevant ref target labels in compound_statement to more precise locations.

This was referenced Aug 14, 2022
Closed
Merged
Merged
miss-islington added a commit that referenced this pull request Sep 8, 2022
@miss-islington @iritkatriel
gh-95914: Add paragraph about PEP 654 in main body of 'What's New in … …
1276e73 
…3.11' (GH-95937)

(cherry picked from commit 1402d2c)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@CAM-Gerlach CAM-Gerlach mentioned this pull request Sep 26, 2022
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments

@CAM-Gerlach CAM-Gerlach CAM-Gerlach requested changes

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iritkatriel @miss-islington @bedevere-bot @CAM-Gerlach @gvanrossum @ezio-melotti