{{ message }}
bpo-40222: Mark exception table function in the dis module as private#95960
Closed
pablogsal wants to merge 72 commits into
Closed
bpo-40222: Mark exception table function in the dis module as private#95960pablogsal wants to merge 72 commits into
pablogsal wants to merge 72 commits into
Conversation
Execute as "python -m pegen.vm_generator" in the Tools folder
17 hidden items
Load more…
This is not complete, but I want to get to left-recursion before I fix
this, and I don't actually understand the code generator well enough
to know how to make it work for `&('foo'|'bar')`.
It definitely makes parsing xxl.py 5-10% slower. :-(
This was super easy. Benchmark time for xxl.py is now around 2.030 seconds. (But this is with a super simple grammar. We'll have to see what is will be with the real grammar.)
Also silence compiler warning about default case in call_action().
Also cleaned up the type of the second arg to add_opcode() -- it now must always be a string, the one call that didn't pass a string now calls str().
(The bad news: it's currently twice as slow as the 'new' parser.)
This reduces the number of is_memoized calls dramatically, to what it is for the recursive-descent parser (+1 for the root). However we still have 50% more calls to insert_memo. This has to be investigated later.
It's not any faster than before though.
Member
Author
|
Apologies for the noise :( |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.