◐ Shell
reader mode source ↗
Skip to content

[3.11] GH-95736: fix IsolatedAsyncioTestCase to initialize Runner bef…#96042

Merged
pablogsal merged 1 commit into
python:3.11from
kumaraditya303:backport-9d51599-3.11
Aug 18, 2022
Merged

[3.11] GH-95736: fix IsolatedAsyncioTestCase to initialize Runner bef…#96042
pablogsal merged 1 commit into
python:3.11from
kumaraditya303:backport-9d51599-3.11

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Aug 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Aug 17, 2022
@kumaraditya303 kumaraditya303 force-pushed the backport-9d51599-3.11 branch 2 times, most recently from e005772 to e9c7d24 Compare August 17, 2022 11:28
@kumaraditya303 kumaraditya303 mentioned this pull request Aug 17, 2022
Closed
@kumaraditya303 @serhiy-storchaka
[3.11] pythonGH-95736: fix IsolatedAsyncioTestCase to initialize Runn… …
ab95cf7 
…er before calling setup functions (pythonGH-95898)

(cherry picked from commit 9d51599)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2022
@bedevere-bot

bedevere-bot commented Aug 17, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit ab95cf7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2022
gvanrossum
gvanrossum approved these changes Aug 17, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I discussed this with @pablogsal and he says it's okay to backport. He will review and approve when he's seen the code.

@gvanrossum

gvanrossum commented Aug 17, 2022

Copy link
Copy Markdown
Member

Marked it as do-not-merge just to give @pablogsal a chance to review before it is merged. Pablo, once you agree that this can be merged into 3.11 please remove that label and approve the PR.

pablogsal
pablogsal approved these changes Aug 18, 2022
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

Thanks for pinging me! 👍

@pablogsal pablogsal merged commit b68ea2a into python:3.11 Aug 18, 2022
@kumaraditya303 kumaraditya303 deleted the backport-9d51599-3.11 branch August 18, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303 @bedevere-bot @gvanrossum @pablogsal