◐ Shell
reader mode source ↗
Skip to content

GH-96803: Add three C-API functions to make _PyInterpreterFrame less opaque for users of PEP 523.#96849

Merged
markshannon merged 9 commits into
python:mainfrom
faster-cpython:py-interpreter-frame-api
May 5, 2023
Merged

GH-96803: Add three C-API functions to make _PyInterpreterFrame less opaque for users of PEP 523.#96849
markshannon merged 9 commits into
python:mainfrom
faster-cpython:py-interpreter-frame-api

Conversation

@markshannon

@markshannon markshannon commented Sep 15, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal
pablogsal approved these changes Sep 15, 2022
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

vstinner
vstinner reviewed Sep 15, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Maybe added these functions to cpython/pyframe.h instead.

I don't know why frameobject.h is not included by Python.h: you have to include it explicitly, which goes against the advice of only including Python.h in C extensions. So I recently added pyframe.h which is included by Python.h. Maybe we should just move frameobject.h content into pyframe.h.

In Python 3.11, I moved multiple functions from frameobject.h to pyframe.h: 27b9894

markshannon and others added 3 commits September 15, 2022 17:02
@markshannon @vstinner
Update Misc/NEWS.d/next/C API/2022-09-15-15-21-34.gh-issue-96803.ynBK… …
821de76 
…IS.rst

Co-authored-by: Victor Stinner <vstinner@python.org>
@markshannon @vstinner
Update Include/cpython/frameobject.h …
5aed2cb 
Co-authored-by: Victor Stinner <vstinner@python.org>
@markshannon
Attempt to fix rst formatting.
fea57fb
@smontanaro

smontanaro commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why? Read here.)

This PR has been idle for awhile. Can it be merged or is there more to do?

@iritkatriel

iritkatriel commented May 5, 2023

Copy link
Copy Markdown
Member

Is this supposed to be in 3.12?

@markshannon

markshannon commented May 5, 2023

Copy link
Copy Markdown
Member Author

We might as well. I'm unsure how people use PEP 523, but this should help.

I'll add the Unstable prefix to them now that PEP 689 has been accepted.

@markshannon markshannon requested a review from iritkatriel as a code owner May 5, 2023 11:23
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
Open
@markshannon markshannon force-pushed the py-interpreter-frame-api branch 2 times, most recently from 67a5450 to 7fbece8 Compare May 5, 2023 16:23
@markshannon markshannon merged commit a0df9ee into python:main May 5, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2 …
baacf5f 
* main:
  pythongh-99113: Add PyInterpreterConfig.own_gil (pythongh-104204)
  pythongh-104146: Remove unused var 'parser_body_declarations' from clinic.py (python#104214)
  pythongh-99113: Add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED (pythongh-104205)
  pythongh-104108: Add the Py_mod_multiple_interpreters Module Def Slot (pythongh-104148)
  pythongh-99113: Share the GIL via PyInterpreterState.ceval.gil (pythongh-104203)
  pythonGH-100479: Add `pathlib.PurePath.with_segments()` (pythonGH-103975)
  pythongh-69152: Add _proxy_response_headers attribute to HTTPConnection (python#26152)
  pythongh-103533: Use PEP 669 APIs for cprofile (pythonGH-103534)
  pythonGH-96803: Add three C-API functions to make _PyInterpreterFrame less opaque for users of PEP 523. (pythonGH-96849)
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@markshannon @jbower-fb
pythonGH-96803: Add three C-API functions to make _PyInterpreterFrame… …
5405b60 
… less opaque for users of PEP 523. (pythonGH-96849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@pablogsal pablogsal pablogsal approved these changes

@carljm carljm carljm approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@markshannon @smontanaro @iritkatriel @carljm @vstinner @pablogsal @bedevere-bot