◐ Shell
reader mode source ↗
Skip to content

[3.10] gh-95778: Mention sys.set_int_max_str_digits() in error message (GH-96874)#96876

Merged
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-e841ffc-3.10
Sep 16, 2022
Merged

[3.10] gh-95778: Mention sys.set_int_max_str_digits() in error message (GH-96874)#96876
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-e841ffc-3.10

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 16, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

When ValueError is raised if an integer is larger than the limit,
mention sys.set_int_max_str_digits() in the error message.
(cherry picked from commit e841ffc)

Co-authored-by: Victor Stinner vstinner@python.org

@vstinner @miss-islington
pythongh-95778: Mention sys.set_int_max_str_digits() in error message (… …
1aaed06 
…pythonGH-96874)

When ValueError is raised if an integer is larger than the limit,
mention sys.set_int_max_str_digits() in the error message.
(cherry picked from commit e841ffc)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Sep 16, 2022
Merged
vstinner
vstinner requested changes Sep 16, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, good bot.

@bedevere-bot

bedevere-bot commented Sep 16, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vstinner
vstinner approved these changes Sep 16, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, good bot.

@miss-islington

miss-islington commented Sep 16, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit ce11f39 into python:3.10 Sep 16, 2022
@miss-islington miss-islington deleted the backport-e841ffc-3.10 branch September 16, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miss-islington @bedevere-bot @vstinner