{{ message }}
bpo-29548: Fix some inefficient call API usage#97
Merged
methane merged 4 commits intoFeb 16, 2017
Merged
Conversation
Member
Sorry, something went wrong.
vstinner
requested changes
Feb 14, 2017
vstinner
requested changes
Feb 15, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Oh, I missed the "arg" variable.
Sorry, something went wrong.
vstinner
approved these changes
Feb 16, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
This change removes the "static" declaration from the function slp_switch(). This forces the compiler to adhere to the ABI specification. On i386 and amd64 it is now save to configure stackless with --enable-stacklessfewerregisters, except if you compile for darwin. The flag disables explicit saving of %ebp/%rbp. On Unix-like systems the source file slp_transfer.c now gets compiled with the additional flag -fno-inline-functions instead of -O2. https://bitbucket.org/stackless-dev/stackless/issues/98 (grafted from 4f7698499ad53e5fad61fb415fbfe2c036672a9c)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
Mr3x33
added a commit
to Mr3x33/cpython
that referenced
this pull request
Sep 17, 2021
colesbury
referenced
this pull request
in colesbury/nogil
Oct 6, 2021
This replaces the array of qbsr threads with a stack, which allows us to get rid of the stop-the-world call. There was an initialization order bug: registering a new qsbr thread might stop-the-world, but stopping the world requires the thread to already be attached! This will probably make the qsbr scan even slower, but we can improve that in the future. Fixes #97
This was referenced Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
While bpo-29548, some inefficient
PyEval_Call*()usage are found.This is spin off pull request for fixing them.
_PyObject_CallNoArg()when there are no arguments.PyObject_CallMethodinstead of manually callingPy_BuildValue(). (temporary tuple may be skipped)