◐ Shell
reader mode source ↗
Skip to content

[3.9] gh-96848: Fix -X int_max_str_digits option parsing (GH-96988)#97574

Merged
ambv merged 1 commit into
python:3.9from
miss-islington:backport-4135166-3.9
Oct 4, 2022
Merged

[3.9] gh-96848: Fix -X int_max_str_digits option parsing (GH-96988)#97574
ambv merged 1 commit into
python:3.9from
miss-islington:backport-4135166-3.9

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 26, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner vstinner@python.org

@vstinner @miss-islington
pythongh-96848: Fix -X int_max_str_digits option parsing (pythonGH-96988 …
cc89be6 
)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Sep 26, 2022
Merged
vstinner
vstinner approved these changes Sep 26, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, good bot.

@miss-islington

miss-islington commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a failure or timed out ❌.

@ambv

ambv commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Test failing on Windows, looks legitimate: AssertionError: 0.015625 not less than 0.013671875. I'll re-run just in case.

@miss-islington

miss-islington commented Oct 4, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington

miss-islington commented Oct 4, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@ambv

ambv commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

...and it passed 🤔

@ambv ambv mentioned this pull request Oct 4, 2022
Merged
@ambv ambv merged commit 358b7a4 into python:3.9 Oct 4, 2022
@miss-islington miss-islington deleted the backport-4135166-3.9 branch October 4, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @ambv @vstinner @bedevere-bot