{{ message }}
GH-97002: Prevent _PyInterpreterFrames from backing more than one PyFrameObject#97996
Merged
markshannon merged 4 commits intoOct 6, 2022
Merged
GH-97002: Prevent _PyInterpreterFrames from backing more than one PyFrameObject#97996markshannon merged 4 commits into
_PyInterpreterFrames from backing more than one PyFrameObject#97996markshannon merged 4 commits into
Conversation
Member
Sorry, something went wrong.
brandtbucher
added
sprint
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
type-crash
needs backport to 3.11
only security fixes
labels
Oct 6, 2022
Contributor
|
Thanks @brandtbucher for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 6, 2022
… one `PyFrameObject` (pythonGH-97996) (cherry picked from commit 21a2d9f) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Oct 8, 2022
* main: pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996) pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984) fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965) pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990) pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992) pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974) pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785) pythongh-86482: Document assignment expression need for ()s (python#23291) pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
… one `PyFrameObject` (pythonGH-97996)
andersk
reviewed
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer
Assignees
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
There is a nasty situation where a GC collection during
PyFrameObjectallocation could create multiplePyFrameObjects for the same_PyInterpreterFrame, which breaks our ownership rules and creates all sorts of opportunities for accessing corrupted memory.If this happens, we just keep the
PyFrameObjectthat has already been exposed to user code, and throw away the duplicate.PyFrameObjects can be created for a single_PyInterpreterFrame#97002