◐ Shell
reader mode source ↗
Skip to content

bpo-34962: make doctest in Doc now passes, and is enforced in CI#9806

Merged
JulienPalard merged 33 commits into
python:masterfrom
matrixise:bpo-34962
Oct 12, 2018
Merged

bpo-34962: make doctest in Doc now passes, and is enforced in CI#9806
JulienPalard merged 33 commits into
python:masterfrom
matrixise:bpo-34962

Conversation

@matrixise

@matrixise matrixise commented Oct 11, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@matrixise
wip: fix doctest
0f4520d
@matrixise
fix doctest for library/re.rst
36ed172
@matrixise
use .. doctest:: instead of .. testcode:: because we need to keep the… …
cc14274 
… presentation
@matrixise
Add testsetup
01dea04
@matrixise
pass from 258 to 240
068485a
@matrixise
add SomeClass in testsetup -> 235 tests failed
cd14acb
@matrixise
update
9407247
@matrixise
update
249ff3d
@matrixise
add new target in travis
c9d6175
@matrixise
fix the whitespace
1fa9509
@matrixise
try to use 3.7
305ee74
@matrixise
disable the warnings into errors
1517a37
@matrixise
use a block code instead of doctest
7c03c41
@matrixise
Disable some builds
2e1db29
@matrixise
Fix with ellipsis
21b3db0
@matrixise
Disable the quiet flag of sphinx
526f366
@matrixise
Merge the tests and execute doctests just after the build
5764cdb
@matrixise
Execute the doctests with the tests
e500b59
@matrixise
reset
1312c42
@matrixise
execute doctest
a12dbe7
@matrixise
Execute doctest just after the tests
0ed453b
@matrixise
pin the version of sphinx
be41d1c
@matrixise
Reuse >>> for the doctests
f8238a4
@matrixise
Pass the tests if tkinter is not installed
e5f6478
@matrixise
Rename duplicated ref to a new ref
9d14da2
@matrixise
Use the last version of sphinx
bece51b
@matrixise
Add News entry
8263dee
@JulienPalard

JulienPalard commented Oct 11, 2018

Copy link
Copy Markdown
Member

Needs python/docsbuild-scripts#59 to avoid a huge flood of warnings (yet the docs build properly at the end).

@bedevere-bot

bedevere-bot commented Oct 11, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@JulienPalard

JulienPalard commented Oct 11, 2018

Copy link
Copy Markdown
Member

I remove the DO-NOT-MERGE label as we're now having Sphinx 1.8.1 on docs.python.org.

@JulienPalard JulienPalard merged commit 859c068 into python:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabella csabella

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matrixise @JulienPalard @bedevere-bot @csabella @the-knights-who-say-ni