◐ Shell
reader mode source ↗
Skip to content

gh-95913: Edit Faster CPython section in 3.11 WhatsNew#98429

Merged
Fidget-Spinner merged 8 commits into
python:mainfrom
CAM-Gerlach:whatsnew-faster-cpython
Mar 7, 2023
Merged

gh-95913: Edit Faster CPython section in 3.11 WhatsNew#98429
Fidget-Spinner merged 8 commits into
python:mainfrom
CAM-Gerlach:whatsnew-faster-cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Oct 19, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Part of #95913

This PR cross-references, sphinxifies and copyedits the Faster CPython section of the What's New in Python 3.11 document. Specifically, it:

  • Converts the FAQ from a manually formatted static block to standard, linkable headings and ref target labels
  • Adds Sphinx roles and cross references to the appropriate constructs missing them
  • Fixes and refines reST syntax
  • Refines some of the writing to improve readability and reduce choppiness
  • Fixes/tweaks a few other minor textual issues

Notably, it takes care not to make any substantive additions/changes to the actual content, to expedite review, as it already was assumed to be reasonably complete

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Oct 19, 2022
@CAM-Gerlach CAM-Gerlach force-pushed the whatsnew-faster-cpython branch from dced4fa to 3d614ee Compare October 19, 2022 04:31
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 19, 2022
Closed
33 tasks
@Fidget-Spinner Fidget-Spinner self-requested a review October 19, 2022 11:32
Fidget-Spinner
Fidget-Spinner reviewed Oct 19, 2022
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good in general.

@CAM-Gerlach @Fidget-Spinner
Apply textual clarifications from Ken Jin …
6fe84e8 
Co-authored-by: Ken Jin <kenjin@python.org>
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 19, 2022
Merged
@mdboom mdboom requested a review from markshannon October 19, 2022 21:12
@CAM-Gerlach

CAM-Gerlach commented Mar 6, 2023

Copy link
Copy Markdown
Member Author

Hey @Fidget-Spinner , did you get a chance to give this another look?

@Fidget-Spinner

Fidget-Spinner commented Mar 6, 2023

Copy link
Copy Markdown
Member

Oh gosh I'm so sorry that I forgot about this. Thanks for the ping.

@Fidget-Spinner @CAM-Gerlach
LOAD_GLOBAL without call …
0e898cd 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@Fidget-Spinner Fidget-Spinner merged commit 80b19a3 into python:main Mar 7, 2023
@miss-islington

miss-islington commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Mar 7, 2023

Copy link
Copy Markdown

GH-102490 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 7, 2023
Fidget-Spinner pushed a commit that referenced this pull request Mar 7, 2023
@miss-islington @CAM-Gerlach
[3.11] gh-95913: Edit Faster CPython section in 3.11 WhatsNew (GH-98429… …
df3ed54 
…) (GH-102490)

gh-95913: Edit Faster CPython section in 3.11 WhatsNew (GH-98429)
(cherry picked from commit 80b19a3)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
carljm added a commit to carljm/cpython that referenced this pull request Mar 7, 2023
@carljm
Merge branch 'main' into nodeaddict …
e391218 
* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2 …
1c019a7 
* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CAM-Gerlach @Fidget-Spinner @miss-islington @bedevere-bot