◐ Shell
reader mode source ↗
Skip to content

[3.10] gh-98548: Fix -ne shell operator spelling#98555

Merged
ambv merged 2 commits into
python:3.10from
sterliakov:gh-98548
Oct 28, 2022
Merged

[3.10] gh-98548: Fix -ne shell operator spelling#98555
ambv merged 2 commits into
python:3.10from
sterliakov:gh-98548

Conversation

@sterliakov

@sterliakov sterliakov commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

gh-98548: Workflow not equal operator spelling

This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.

This bug is present on 3.10 and 3.11 branches only.

@bedevere-bot

bedevere-bot commented Oct 22, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost

ghost commented Oct 22, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@sterliakov sterliakov changed the title Fix -ne shell operator spelling Oct 22, 2022
@sterliakov sterliakov changed the title gh-98548: Fix -ne shell operator spelling Oct 22, 2022
@sterliakov

sterliakov commented Oct 22, 2022

Copy link
Copy Markdown
Contributor Author

Unfortunately, I cannot add "skip news" label manually, and I doubt that CI typo fix is worth an entry.

@sterliakov sterliakov mentioned this pull request Oct 22, 2022
Merged
@hauntsaninja

hauntsaninja commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Thanks for this! Let's discuss on the 3.11 PR: #98556 (review)

@JelleZijlstra JelleZijlstra self-assigned this Oct 26, 2022
@ambv ambv merged commit db1c3d6 into python:3.10 Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sterliakov @bedevere-bot @hauntsaninja @ambv @JelleZijlstra