◐ Shell
reader mode source ↗
Skip to content

Fix: Mac/Extras.install.py，Can not filter osx .DS_store file, skip issue#98580

Closed
zhangbo2012 wants to merge 6 commits into
python:mainfrom
zhangbo2012:B_MAC.Extras.install
Closed

Fix: Mac/Extras.install.py，Can not filter osx .DS_store file, skip issue#98580
zhangbo2012 wants to merge 6 commits into
python:mainfrom
zhangbo2012:B_MAC.Extras.install

Conversation

@zhangbo2012

@zhangbo2012 zhangbo2012 commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Fix: Mac/Extras.install.py，Can not filter osx .DS_store file, skip issue

Mac/Extras.install.py，Can not filter osx DS_store file

As

if name == '.DS_store': return 0

But in OSX, Real File Name is .DS_Store, like this

(venv) zhangbo@zhangbodeMacBook-Pro a2 % ll -a
total 16
drwxr-xr-x  4 zhangbo  staff   128 Oct 22 17:34 .
drwxr-xr-x  8 zhangbo  staff   256 Oct 22 17:18 ..
-rw-r--r--@ 1 zhangbo  staff  6148 Oct 22 17:17 .DS_Store
drwxr-xr-x  3 zhangbo  staff    96 Oct 22 17:23 123

So we need update .DS_store to .DS_Store

Thanks to @arhadthedev show a more clean code

@zhangbo2012 zhangbo2012 requested a review from a team as a code owner October 24, 2022 01:54
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost

ghost commented Oct 24, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedev arhadthedev mentioned this pull request Oct 24, 2022
Closed
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot

bedevere-bot commented Oct 25, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot

bedevere-bot commented Oct 27, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot

bedevere-bot commented Oct 28, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot

bedevere-bot commented Oct 31, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@zhangbo2012 zhangbo2012 marked this pull request as draft November 1, 2022 01:58
@ned-deily

ned-deily commented Nov 21, 2022

Copy link
Copy Markdown
Member

Superseded by #98943

@ned-deily ned-deily closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangbo2012 @bedevere-bot @ned-deily