◐ Shell
reader mode source ↗
Skip to content

gh-95913: Fix, sort & expand pending removal sect in 3.11 WhatsNew#98583

Merged
encukou merged 6 commits into
python:mainfrom
CAM-Gerlach:whatsnew-edit-pending-removal
Oct 24, 2022
Merged

gh-95913: Fix, sort & expand pending removal sect in 3.11 WhatsNew#98583
encukou merged 6 commits into
python:mainfrom
CAM-Gerlach:whatsnew-edit-pending-removal

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Oct 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #95913

This PR copyedits, sorts and fixes the syntax of the Pending Removal section of the What's New in Python 3.11 document. In particular, it:

  • Fixes several items that had typos, were duplicated, or otherwise broken
  • Structures the list by modules, then APIs within modules, sorted alphabetically
  • De-resolves references to undocumented APIs to avoid inefficiency and warnings

It also adds several missing modules pending removal in 3.12 but not previously listed, specifically:

  • asynchat
  • asyncore
  • imp
  • The typing.io namespace
  • The typing.re namespace
  • Numerous deprecated aliases (assert* and fail*) in the unittest module that were bumped from 3.11 to 3.12 in beta 1, but not listed anywhere in the document

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 24, 2022
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes labels Oct 24, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 24, 2022
Closed
33 tasks
@CAM-Gerlach CAM-Gerlach force-pushed the whatsnew-edit-pending-removal branch from 974596e to 3f17a8e Compare October 24, 2022 06:38
@pablogsal pablogsal changed the title gh-95913: Fix, sort & expand Pending Rm sect in 3.11 WhatsNew Oct 24, 2022
@pablogsal

pablogsal commented Oct 24, 2022

Copy link
Copy Markdown
Member

The docs are failing due to:

WARNING: undefined label: deprecated-aliases

@encukou @JelleZijlstra
Update Doc/whatsnew/3.11.rst …
5090fb8 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@encukou encukou merged commit e19c2b9 into python:main Oct 24, 2022
@miss-islington

miss-islington commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@CAM-Gerlach @miss-islington
pythongh-95913: Fix, sort & expand pending removal sect in 3.11 Whats… …
6ecd75e 
…New (pythonGH-98583)

* Fix names/references of pending removal APIs

* Sort list of APIs pending removal alphabetically

* Add missing modules/submodules pending removal in 3.12

* Add table of unittest deprecated aliases to 3.11 What's New

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
(cherry picked from commit e19c2b9)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98600 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington added a commit that referenced this pull request Oct 25, 2022
@miss-islington @CAM-Gerlach
gh-95913: Fix, sort & expand pending removal sect in 3.11 WhatsNew (G… …
08c3c91 
…H-98583)

* Fix names/references of pending removal APIs

* Sort list of APIs pending removal alphabetically

* Add missing modules/submodules pending removal in 3.12

* Add table of unittest deprecated aliases to 3.11 What's New

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
(cherry picked from commit e19c2b9)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Assignees

No one assigned

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CAM-Gerlach @pablogsal @miss-islington @bedevere-bot @encukou @JelleZijlstra