gh-98940: Fix Mac/Extras.install.py File filter bug#98943
Conversation
…C_.rst fix news.d Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
Sorry, you need @python/macos-team for this, not me. |
Sorry, something went wrong.
|
Oh, sorry. You are from Windows team :) |
Sorry, something went wrong.
ronaldoussoren
left a comment
There was a problem hiding this comment.
Patch looks good to me.
Sorry, something went wrong.
|
Thanks @zhangbo2012 for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot wasm32-emscripten node (pthreads) 3.x has failed when building commit ea88d34. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1050/builds/848 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Tests result: FAILURE == 338 tests OK. 10 slowest tests:
1 test failed: 94 tests skipped: Total duration: 21 min 33 sec Click to see traceback logsTraceback (most recent call last):
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-pthreads/build/Lib/test/test___all__.py", line 129, in test_all
self.check_all(modname)
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-pthreads/build/Lib/test/test___all__.py", line 43, in check_all
with warnings_helper.check_warnings(
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-pthreads/build/Lib/contextlib.py", line 144, in __exit__
next(self.gen)
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-pthreads/build/Lib/test/support/warnings_helper.py", line 185, in _filterwarnings
raise AssertionError("unhandled warning %s" % reraise[0])
AssertionError: unhandled warning {message : SyntaxWarning("invalid escape sequence '\\('"), category : 'SyntaxWarning', filename : '/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-pthreads/build/Lib/test/test_enum.py', lineno : 1481, line : None}
|
Sorry, something went wrong.
gh-98940: Fix Mac/Extras.install.py Can not filter osx .DS_store file
Mac/Extras.install.py,Can not filter osx DS_store file
As
But in OSX, Real File Name is
.DS_Store, like this(venv) zhangbo@zhangbodeMacBook-Pro a2 % ll -a total 16 drwxr-xr-x 4 zhangbo staff 128 Oct 22 17:34 . drwxr-xr-x 8 zhangbo staff 256 Oct 22 17:18 .. -rw-r--r--@ 1 zhangbo staff 6148 Oct 22 17:17 .DS_Store drwxr-xr-x 3 zhangbo staff 96 Oct 22 17:23 123So we need update .DS_store to .DS_Store
Thanks to @arhadthedev show a more clean code