{{ message }}
gh-90716: Fix pylong_int_from_string() refleak#99094
Merged
vstinner merged 1 commit intoNov 4, 2022
Merged
Conversation
Member
Sorry, something went wrong.
Fix validated by:
$ ./python -m test -R 3:3 test_int
Tests result: SUCCESS
kumaraditya303
approved these changes
Nov 4, 2022
kumaraditya303
left a comment
kumaraditya303
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Member
|
Heh, thanks! |
Sorry, something went wrong.
Member
Author
|
I wrote an article on this fix :-) https://vstinner.github.io/debug-python-refleak.html
From what I understood, the refleak existed before 4c4b5ce. It's just that thanks to the added test, the Refleaks buildbot spotted the leak. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Fix validated by: