◐ Shell
reader mode source ↗
Skip to content

gh-90868: Add _PyStaticObject_CheckRefcnt() function#99261

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:staticobj_check_refcnt
Nov 9, 2022
Merged

gh-90868: Add _PyStaticObject_CheckRefcnt() function#99261
vstinner merged 1 commit into
python:mainfrom
vstinner:staticobj_check_refcnt

Conversation

@vstinner

@vstinner vstinner commented Nov 8, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Add _PyStaticObject_CheckRefcnt() function to make _PyStaticObjects_CheckRefcnt() shorter. Use
_PyObject_ASSERT_FAILED_MSG() to log the object causing the fatal error.

@bedevere-bot bedevere-bot mentioned this pull request Nov 8, 2022
Closed
@vstinner

vstinner commented Nov 8, 2022

Copy link
Copy Markdown
Member Author

@ericsnowcurrently @kumaraditya303: This PR makes _PyStaticObjects_CheckRefcnt() more readable and shorter, what do you think?

ericsnowcurrently
ericsnowcurrently requested changes Nov 8, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I have one suggestion. Otherwise this looks good.

@bedevere-bot

bedevere-bot commented Nov 8, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner
gh-90868: Add _PyStaticObject_CheckRefcnt() function …
2987e19 
Add _PyStaticObject_CheckRefcnt() function to make
_PyStaticObjects_CheckRefcnt() shorter. Use
_PyObject_ASSERT_FAILED_MSG() to log the object causing the fatal
error.
@vstinner

vstinner commented Nov 8, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Nov 8, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

ericsnowcurrently
ericsnowcurrently approved these changes Nov 9, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@vstinner vstinner merged commit 0124b5d into python:main Nov 9, 2022
@vstinner vstinner deleted the staticobj_check_refcnt branch November 9, 2022 07:40
@vstinner

vstinner commented Nov 9, 2022

Copy link
Copy Markdown
Member Author

Merged, thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @bedevere-bot @ericsnowcurrently