◐ Shell
reader mode source ↗
Skip to content

gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks#99414

Merged
gvanrossum merged 1 commit into
python:mainfrom
xiaochen7:close-event-loop
Nov 12, 2022
Merged

gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks#99414
gvanrossum merged 1 commit into
python:mainfrom
xiaochen7:close-event-loop

Conversation

@xiaochen7

@xiaochen7 xiaochen7 commented Nov 12, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot mentioned this pull request Nov 12, 2022
Closed
gvanrossum
gvanrossum approved these changes Nov 12, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks!

@gvanrossum gvanrossum merged commit 99972dc into python:main Nov 12, 2022
@gvanrossum

gvanrossum commented Nov 12, 2022

Copy link
Copy Markdown
Member

@kumaraditya303 Should we backport this?

@kumaraditya303 kumaraditya303 added the needs backport to 3.11 only security fixes label Nov 13, 2022
@miss-islington

miss-islington commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @xiaochen7 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Sorry @xiaochen7 and @gvanrossum, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 99972dc7450f1266e39202012827f4f3c995b0ca 3.11

@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Nov 13, 2022
@miss-islington

miss-islington commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @xiaochen7 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 13, 2022

Copy link
Copy Markdown

GH-99424 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 13, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2022
@xiaochen7 @miss-islington
pythongh-99357: Close the event loop when it is no longer used in tes… …
29f11df 
…t_uncancel_structured_blocks (pythonGH-99414)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <chenxiao_7@163.com>
@kumaraditya303

kumaraditya303 commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Should we backport this?

Let's backport to 3.11.

gvanrossum pushed a commit that referenced this pull request Nov 14, 2022
@miss-islington @xiaochen7
[3.11] gh-99357: Close the event loop when it is no longer used in te… …
90de4b7 
…st_uncancel_structured_blocks (GH-99414) (#99424)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <chenxiao_7@163.com>
@xiaochen7 xiaochen7 deleted the close-event-loop branch November 16, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@gvanrossum gvanrossum

Labels

tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xiaochen7 @gvanrossum @miss-islington @bedevere-bot @kumaraditya303 @AlexWaygood