gh-93649: Split memory and docstring tests from _testcapimodule.c#99517
gh-93649: Split memory and docstring tests from _testcapimodule.c#99517erlend-aasland merged 2 commits into
Conversation
|
Should we also add the three tracemalloc tests to |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I suggest to rename "mem.c" to "pymem.c", since most tests are about the "PyMem" API: https://docs.python.org/dev/c-api/memory.html
But I'm also fine with "mem" name, it's up to you.
Sorry, something went wrong.
|
I think I prefer the "mem" name, but I'm not sure it matters much really. What do you think about including the tracemalloc tests? |
Sorry, something went wrong.
We can add the tracemalloc tests later if we find out they should live in |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot wasm32-emscripten node (dynamic linking) 3.x has failed when building commit 00437ad. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1056/builds/852 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Tests result: FAILURE == 334 tests OK. 10 slowest tests:
1 test failed: 98 tests skipped: Total duration: 19 min 49 sec Click to see traceback logsTraceback (most recent call last):
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-dl/build/Lib/test/test___all__.py", line 129, in test_all
self.check_all(modname)
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-dl/build/Lib/test/test___all__.py", line 43, in check_all
with warnings_helper.check_warnings(
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-dl/build/Lib/contextlib.py", line 144, in __exit__
next(self.gen)
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-dl/build/Lib/test/support/warnings_helper.py", line 185, in _filterwarnings
raise AssertionError("unhandled warning %s" % reraise[0])
AssertionError: unhandled warning {message : SyntaxWarning("invalid escape sequence '\\('"), category : 'SyntaxWarning', filename : '/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-dl/build/Lib/test/test_enum.py', lineno : 1481, line : None}
|
Sorry, something went wrong.
|
@erlend-aasland can you please review my fix of this failure? It happens for each PR right now :( Link: #99519 |
Sorry, something went wrong.
Yep, it makes sense to move them in mem.c. |
Sorry, something went wrong.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.