◐ Shell
reader mode source ↗
Skip to content

gh-99593: Add tests for Unicode C API (part 2)#99868

Merged
vstinner merged 5 commits into
python:mainfrom
serhiy-storchaka:test-unicode-capi-part2
May 4, 2023
Merged

gh-99593: Add tests for Unicode C API (part 2)#99868
vstinner merged 5 commits into
python:mainfrom
serhiy-storchaka:test-unicode-capi-part2

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 29, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Add tests for lower-level functions.

@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API (part 2) …
f8754d7 
Add tests for lower-level functions.
@bedevere-bot bedevere-bot mentioned this pull request Nov 29, 2022
Closed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 29, 2022
This was referenced Nov 29, 2022
Merged
Closed
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review November 30, 2022 17:19
vstinner
vstinner reviewed Dec 1, 2022
View reviewed changes
4 hidden conversations Load more…
@serhiy-storchaka

serhiy-storchaka commented Dec 3, 2022

Copy link
Copy Markdown
Member Author

Thank you for your review Victor.

vstinner
vstinner approved these changes Dec 5, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Thanks for my addressing my review.

@hugovk

hugovk commented Apr 7, 2023

Copy link
Copy Markdown
Member

@serhiy-storchaka Victor approved this, ready to merge?

(I removed the 3.10 backport label, it's now security only)

@vstinner vstinner enabled auto-merge (squash) May 4, 2023 14:59
vstinner
vstinner approved these changes May 4, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@vstinner

vstinner commented May 4, 2023

Copy link
Copy Markdown
Member

The CI test "DO-NOT-MERGE / unresolved review" was blocked on "Waiting for status to be reported". I tried to update the PR on main to see if it does unblock the PR.

@vstinner vstinner merged commit 2ba931f into python:main May 4, 2023
@miss-islington

miss-islington commented May 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 4, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka and @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2ba931ff727395cf89b290ed313a8e15db0bfcf1 3.11

@vstinner vstinner removed the needs backport to 3.11 only security fixes label May 4, 2023
@vstinner

vstinner commented May 4, 2023

Copy link
Copy Markdown
Member

Merged, thanks @serhiy-storchaka.

@serhiy-storchaka: If you consider that this change should be backported to Python 3.11, go ahead. But the automated backport failed for an unknown reason.

carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2 …
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Jul 10, 2023
@miss-islington

miss-islington commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2ba931ff727395cf89b290ed313a8e15db0bfcf1 3.12

@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.12 only security fixes label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @hugovk @vstinner @miss-islington @bedevere-bot @arhadthedev