Don't force table widths in versions.rst#1041
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
ezio-melotti
left a comment
There was a problem hiding this comment.
I added these widths for two reasons:
- Make the columns wide enough to fit their content, and prevent it to be split on two lines
- Make the two tables have the same widths and therefore be aligned
Admittedly I think I only tested it on Firefox, which might explain different behaviors on Chrome it other browsers. IIRC there was a discussion about them in the original PR, and eventually I decided to keep them.
Sorry, something went wrong.
Unfortunately, that's the exact thing it's failing to do, but removing the
If you just want the tables to have the same width, setting the (That's with
Or, it could be that it did originally fit, but some values have gotten wider/narrower since then. That "Georg Brandl, Ned Deily (3.3.7+)" string in the unsupported table is an outlier, and it's going to force that one out of whack no matter what, compared to the supported-versions table. I'm not personally convinced that it's really worth trying to struggle against that, but YMMV. For any table where the data isn't static, fixed column widths will inevitably fall out of alignment with reality unless they're constantly being adjusted to account for every single change in the data. IMHO, that kind of thing gets filed under, "that's the code's problem to solve, not mine!" |
Sorry, something went wrong.
No, actually, FWIW the current live page does indeed still lay out un-wrapped in Firefox. But only in Firefox, I guess, which... |
Sorry, something went wrong.
In the original discussion I'm still using Firefox, so I don't know if the issue got fixed by Firefox, Sphinx, or if it's simply because I'm using a different monitor (which affects the width of the viewport).
This sounds like a good compromise. I tested locally with
Agreed -- aligned columns are nice to have, but hardly essential. IOW, I'm fine with replacing the current |
Sorry, something went wrong.
@ferdnyc Please could you make this change? |
Sorry, something went wrong.
Setting `:widths:` for individual columns leads to weird wrapping, as some columns are too narrow. Just setting the table to 100% width and letting Sphinx figure out the distribution, OTOH, looks fine. Let the software be smart. Signed-off-by: FeRD (Frank Dana) <ferdnyc@gmail.com>
c06e530 to
68d56d6
Compare
March 14, 2023 12:34
|
Done, sorry for the delay. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Really, Firefox!??! Augh! 😞 |
Sorry, something went wrong.
|
To be fair, it was "Really, Chrome!??! [sic] Augh!" before, heh... |
Sorry, something went wrong.
|
Firefox on Linux looks good, even if I horizontally squish the window (up to a certain point, it eventually breaks the "end-of-life"). |
Sorry, something went wrong.









Setting
:widths:leads to weird wrapping, as some columns are too narrow. Just letting Sphinx figure it out, OTOH, looks fine. Let the software be smart.Signed-off-by: FeRD (Frank Dana) ferdnyc@gmail.com