◐ Shell
reader mode source ↗
Skip to content

Releasing v2023.5#126

Merged
JulienPalard merged 1 commit into
mainfrom
mdk-releasing
May 12, 2023
Merged

Releasing v2023.5#126
JulienPalard merged 1 commit into
mainfrom
mdk-releasing

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Apr 17, 2023

Copy link
Copy Markdown
Member

No description provided.

@JulienPalard JulienPalard mentioned this pull request Apr 17, 2023
Merged
hugovk
hugovk approved these changes Apr 17, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Perhaps we could include #121 as well? I've appproved it but not merged it.

@pradyunsg

pradyunsg commented Apr 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Perhaps we could include #121 as well?

+1 to this.

@JulienPalard

JulienPalard commented Apr 18, 2023

Copy link
Copy Markdown
Member Author

rebased on top of #121

AA-Turner
AA-Turner approved these changes Apr 20, 2023
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks Julien!

A

@AA-Turner AA-Turner self-requested a review April 20, 2023 21:02
@AA-Turner

AA-Turner commented Apr 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

(#99 needs fixes, which I have found by updating python/cpython#99381 -- working on a PR now. Sorry!)

Edit: Fix is at #127

@hugovk

hugovk commented Apr 25, 2023

Copy link
Copy Markdown
Member

#127 merged 🚀

@JulienPalard JulienPalard force-pushed the mdk-releasing branch 2 times, most recently from d0a8972 to 846add6 Compare April 29, 2023 16:34
@JulienPalard

JulienPalard commented Apr 29, 2023

Copy link
Copy Markdown
Member Author

Rebased on top of #127.

@hugovk

hugovk commented Apr 29, 2023

Copy link
Copy Markdown
Member

Would be great to include #128 as well if someone has a chance to review it :) If not, it can wait until next time.

@JulienPalard

JulienPalard commented Apr 29, 2023

Copy link
Copy Markdown
Member Author

I'll have to disconnect in a few hours for like one week (holidays) so I'm OK for waiting for #128 and release next week with more time to handle it (rolling it to production, monitoring feedbacks,…).

@hugovk

hugovk commented Apr 29, 2023

Copy link
Copy Markdown
Member

Sounds good to me, enjoy your holiday!

@JulienPalard JulienPalard changed the title Releasing v2023.4 May 12, 2023
@JulienPalard

JulienPalard commented May 12, 2023

Copy link
Copy Markdown
Member Author

I'm back! Does this release looks OK to you?

@hugovk

hugovk commented May 12, 2023

Copy link
Copy Markdown
Member

Welcome back, hope you had a relaxing time! The release looks good!

@AA-Turner

AA-Turner commented May 12, 2023

Copy link
Copy Markdown
Member

Same here, looks good!

A

@JulienPalard JulienPalard merged commit 4dbc102 into main May 12, 2023
@JulienPalard JulienPalard deleted the mdk-releasing branch May 12, 2023 15:08
@JulienPalard

JulienPalard commented May 12, 2023

Copy link
Copy Markdown
Member Author

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti ezio-melotti left review comments

@pradyunsg pradyunsg pradyunsg approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JulienPalard @pradyunsg @AA-Turner @hugovk @ezio-melotti