◐ Shell
reader mode source ↗
Skip to content

3.7 translation of tutorial/venv.po#17

Merged
adrianliaw merged 6 commits into
python:3.7from
tai271828:3.7
Aug 22, 2018
Merged

3.7 translation of tutorial/venv.po#17
adrianliaw merged 6 commits into
python:3.7from
tai271828:3.7

Conversation

@tai271828

Copy link
Copy Markdown
Collaborator

This PR merged the work of https://github.com/python/python-docs-zh-tw/pull/10/files and completed the whole session of tutorial/venv.po

@adrianliaw adrianliaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for contributing! I've commented some suggestions in the code review, and they're mostly about conventions or formatting, and some syntax corrections. Please feel free to give comments if you don't agree with some of my suggestions.

23 hidden conversations Load more…
@tai271828

Copy link
Copy Markdown
Collaborator Author

Fixed all stuff suggested in the previous review.

@tai271828

Copy link
Copy Markdown
Collaborator Author

I have built the html to check the syntax. I think the PR is ready to review again now. The only question I have is the quote:

有好幾個子指令: 「search」,」install」,」uninstall」, 「freeze」, 等等。

It looks good in my po file. However, it shows a bit weird in the translated text. Is this expected or a build process bug?

@adrianliaw

Copy link
Copy Markdown
Collaborator

It seems like a problem from Docutils' localised smart quotes [1], there was a same problem in the Japanese translation, thus there was a docutils.conf added in CPython's Doc directory [2] that disables ja localisation's smart quotes. Let's just keep it correct inside the po file for now, I'll send an email to the Doc-SIG some time.

[1] http://docutils.sourceforge.net/docs/user/smartquotes.html#localisation
[2] python/cpython#4006

@adrianliaw adrianliaw merged commit 6be26e4 into python:3.7 Aug 22, 2018
adrianliaw added a commit that referenced this pull request Aug 22, 2018
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants