◐ Shell
reader mode source ↗
Skip to content

Make iscoroutinefunction TypeIs#15928

Open
InvincibleRMC wants to merge 6 commits into
python:mainfrom
InvincibleRMC:iscoroutinefunction-TypeIs
Open

Make iscoroutinefunction TypeIs#15928
InvincibleRMC wants to merge 6 commits into
python:mainfrom
InvincibleRMC:iscoroutinefunction-TypeIs

Conversation

@InvincibleRMC

Copy link
Copy Markdown

Attempt to address #15529

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@github-actions

This comment has been minimized.

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@github-actions

This comment has been minimized.

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@github-actions

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

aiohttp (https://github.com/aio-libs/aiohttp)
- aiohttp/worker.py:76:26: error: Too few arguments  [call-arg]
+ aiohttp/worker.py:73:14: error: Left operand of "or" is always false  [redundant-expr]
- aiohttp/worker.py:76:26: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-call-arg for more info
+ aiohttp/worker.py:73:14: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-redundant-expr for more info
- aiohttp/worker.py:76:26: note: "wsgi" is considered instance variable, to make it class variable use ClassVar[...]
+ aiohttp/worker.py:76:13: error: Statement is unreachable  [unreachable]
+ aiohttp/worker.py:88:9: error: Statement is unreachable  [unreachable]

discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/core.py:2373: error: "Callable[[Command[Any, Any, Any] | Callable[..., Coroutine[Any, Any, Any]]], Command[Any, Any, Any] | Callable[..., Coroutine[Any, Any, Any]]]" has no attribute "predicate"  [attr-defined]
- discord/ext/commands/core.py:2448: error: "Callable[[Command[Any, Any, Any] | Callable[..., Coroutine[Any, Any, Any]]], Command[Any, Any, Any] | Callable[..., Coroutine[Any, Any, Any]]]" has no attribute "predicate"  [attr-defined]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant