chore: add authentication type to GitlabAuthenticationError#1793
chore: add authentication type to GitlabAuthenticationError#1793JohnVillalovos wants to merge 1 commit into
Conversation
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1793 +/- ##
==========================================
+ Coverage 92.02% 92.04% +0.01%
==========================================
Files 76 76
Lines 4790 4801 +11
==========================================
+ Hits 4408 4419 +11
Misses 382 382
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
JohnVillalovos
force-pushed
the
jlvillal/auth_token_type
branch
from
51573dc to
f1239fd
Compare
January 3, 2022 06:41
Add the type of authentication used to the GitlabAuthenticationError exception. Hopefully this will make it easier to help user's debug authentication issues they run into.
JohnVillalovos
force-pushed
the
jlvillal/auth_token_type
branch
from
f1239fd to
cce2202
Compare
January 4, 2022 05:42
There was a problem hiding this comment.
Thanks John! Just a few ideas from my side on this one :) At the beginning I wasn't quite sure about the use case for this, but for authentication errors might be handy with all the job token confusion.
Especially with the job token we could add a link to the endpoints available or something (e.g. have a mapping for the error message).
Sorry, something went wrong.
|
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
Sorry, something went wrong.
|
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
Sorry, something went wrong.
|
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
Sorry, something went wrong.
Reviewers
Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review
Assignees
3 participants
Add the type of authentication used to the GitlabAuthenticationError
exception. Hopefully this will make it easier to help user's debug
authentication issues they run into.