◐ Shell
reader mode source ↗
Skip to content

feat(client): replace basic auth with OAuth ROPC flow#2422

Draft
nejch wants to merge 1 commit into
mainfrom
feat/oauth2-resource-password-flow
Draft

feat(client): replace basic auth with OAuth ROPC flow#2422
nejch wants to merge 1 commit into
mainfrom
feat/oauth2-resource-password-flow

Conversation

@nejch

@nejch nejch commented Dec 11, 2022

Copy link
Copy Markdown
Member

Small step towards #1195, and also to get rid of the old username/password auth.

Also gets rid of the requests-specific HTTPBasicAuth.

@codecov-commenter

codecov-commenter commented Dec 11, 2022 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (45b8930) to head (be7745d).
Report is 148 commits behind head on main.

❗ Current head be7745d differs from pull request most recent head 3733872

Please upload reports for the commit 3733872 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2422      +/-   ##
==========================================
+ Coverage   92.16%   96.17%   +4.00%     
==========================================
  Files          88       88              
  Lines        5708     5692      -16     
==========================================
+ Hits         5261     5474     +213     
+ Misses        447      218     -229
Flag Coverage Δ
api_func_v4 82.57% <81.81%> (?)
cli_func_v4 82.80% <51.51%> (-0.44%) ⬇️
unit 87.66% <100.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gitlab/client.py 98.81% <100.00%> (+2.55%) ⬆️
gitlab/oauth.py 100.00% <100.00%> (ø)

... and 50 files with indirect coverage changes

@nejch nejch force-pushed the feat/oauth2-resource-password-flow branch 2 times, most recently from 7b1a20d to 90be806 Compare December 19, 2022 15:02
@nejch nejch requested a review from lmilbaum December 19, 2022 15:23
@nejch

nejch commented Dec 19, 2022

Copy link
Copy Markdown
Member Author

@lmilbaum this should also help get rid of requests.HTTPBasicAuth for the backend migration, as I just pass a generic tuple in here when used. Both httpx and requests accept tuples.

nejch
nejch commented Feb 2, 2023
View reviewed changes

@nejch nejch left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

@lmilbaum I just realized I left my responses as Pending for weeks :( just clicking submit now :)

@nejch nejch force-pushed the feat/oauth2-resource-password-flow branch from 90be806 to be7745d Compare February 16, 2023 19:22
@nejch nejch force-pushed the feat/oauth2-resource-password-flow branch from be7745d to 7e65adc Compare October 12, 2023 11:16
@nejch nejch marked this pull request as draft October 12, 2023 12:03
@nejch nejch force-pushed the feat/oauth2-resource-password-flow branch from 7e65adc to 3733872 Compare June 8, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos left review comments

+1 more reviewer

@lmilbaum lmilbaum lmilbaum requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nejch nejch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nejch @codecov-commenter @JohnVillalovos @lmilbaum