Drop Python 2 support#1158
Conversation
|
@filmor have you tried just changing the runtime and leaving the tests as-is for a first pass? I looked through the runtime and didn't see a mistake so I think I would start by ruling out problems with the test updating (which can easily be done in a followon branch) |
Sorry, something went wrong.
|
Not needed. The failures before were due to one place where I forgot to replace |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
- Coverage 86.53% 86.25% -0.28%
==========================================
Files 1 1
Lines 297 291 -6
==========================================
- Hits 257 251 -6
Misses 40 40
Continue to review full report at Codecov.
|
Sorry, something went wrong.
lostmsu
left a comment
There was a problem hiding this comment.
OK by me after a couple minor fixes
Sorry, something went wrong.
|
Also, if you don't increase the coverage back to the target, or lower the target a bit, it is going to complain on every subsequent PR. |
Sorry, something went wrong.
|
The coverage is always against master, it will not repeatedly complain. |
Sorry, something went wrong.
Drop Python 2 support
What does this implement/fix? Explain your changes.
Drops support for and all references to Python 2.
Does this close any currently open issues?
Can't find it right now, but I think we had an issue discussing this.
Any other comments?
-/-
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG