◐ Shell
reader mode source ↗
Skip to content

fix compiler warning#1226

Merged
lostmsu merged 8 commits into
pythonnet:masterfrom
koubaa:compiler-warning
Sep 21, 2020
Merged

fix compiler warning#1226
lostmsu merged 8 commits into
pythonnet:masterfrom
koubaa:compiler-warning

Conversation

@koubaa

@koubaa koubaa commented Sep 16, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Sep 16, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          251      251           
  Misses         40       40
Flag Coverage Δ
#setup_linux 64.94% <ø> (ø)
#setup_windows 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef2e6b4...d5de641. Read the comment docs.

@koubaa

koubaa commented Sep 17, 2020

Copy link
Copy Markdown
Contributor Author

@lostmsu please review

filmor
filmor approved these changes Sep 17, 2020
View reviewed changes

@filmor filmor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good to me, can we make PyObject.obj readonly now?

@lostmsu

lostmsu commented Sep 17, 2020

Copy link
Copy Markdown
Member

@koubaa sorry, reviewed, but forgot to submit :-)

@koubaa

koubaa commented Sep 18, 2020

Copy link
Copy Markdown
Contributor Author

Looks good to me, can we make PyObject.obj readonly now?

It's a good thought! I tried it, but PyObject.Dispose sets it to IntPtr.Zero and that is a compiler error.

@lostmsu lostmsu merged commit 451fae6 into pythonnet:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filmor filmor filmor approved these changes

@lostmsu lostmsu lostmsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koubaa @codecov-commenter @lostmsu @filmor