◐ Shell
reader mode source ↗
Skip to content

fix wrongly cased Microsoft.CSHARP.Targets#1271

Merged
lostmsu merged 1 commit into
pythonnet:masterfrom
vivainio:fix-cases
Nov 3, 2020
Merged

fix wrongly cased Microsoft.CSHARP.Targets#1271
lostmsu merged 1 commit into
pythonnet:masterfrom
vivainio:fix-cases

Conversation

@vivainio

@vivainio vivainio commented Nov 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

"dotnet msbuild pythonnet.sln" fails in WSL2 because .targets files are wrongly cased, and Linux is case sensitive.

The command still fails, but at least for different error :).

@dnfadmin

dnfadmin commented Nov 2, 2020 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@vivainio

vivainio commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

For reference, current error is:

/usr/share/dotnet/sdk/3.1.403/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/mnt/c/p/pythonnet/src/embed_tests/Python.EmbeddingTest.csproj]
/usr/share/dotnet/sdk/3.1.403/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/mnt/c/p/pythonnet/src/testing/Python.Test.csproj]
/usr/share/dotnet/sdk/3.1.403/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/mnt/c/p/pythonnet/src/console/Console.csproj]
/usr/share/dotnet/sdk/3.1.403/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/mnt/c/p/pythonnet/src/runtime/Python.Runtime.csproj]
v@B9DPGH2:/mnt/c/p/pythonnet$

@lostmsu

lostmsu commented Nov 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@vivainio pythonnet.sln is a legacy solution. Please, use pythonnet.15.sln for .NET Core

@vivainio

vivainio commented Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

@lostmsu ok, the fix is is csproj files so it doesn't matter.

"dotnet msbuild pythonnet.15.sln" fails similarly, but I 'm not sure it's even supposed to work with Linux yet.

@lostmsu lostmsu merged commit 84e2735 into pythonnet:master Nov 3, 2020
@vivainio vivainio deleted the fix-cases branch November 3, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vivainio @dnfadmin @lostmsu