{{ message }}
1783 Implement Interface And Inherit Class#2028
Merged
lostmsu merged 3 commits intoFeb 3, 2023
Merged
Conversation
Contributor
Sorry, something went wrong.
5 tasks
lostmsu
requested changes
Nov 29, 2022
5 tasks
lostmsu
requested changes
Feb 2, 2023
lostmsu
left a comment
lostmsu
left a comment
Member
There was a problem hiding this comment.
Please, rebase before posting a new iteration.
P.S. sorry for the late response
Sorry, something went wrong.
Added support for multiple inheritance when inheriting from one base class and/or multiple interfaces. Added a unit test verifying that it works with a simple class and interface. This unit test would previously have failed since multiple types are in the class super class list.
- Added exceptions during unintended use of superclasses. - Removed invalid comment. - Improved exceptions from MetaType slightly.
rmadsen-ks
force-pushed
the
1783-ImplementInterfaceAndInheritClass
branch
from
cf4d59a to
7acbb22
Compare
February 2, 2023 21:07
Contributor
Author
|
Thanks for doing the review. I have rebased and fixed things you mentioned. Will you mark the conversations resolved where appropriate? |
Sorry, something went wrong.
lostmsu
approved these changes
Feb 3, 2023
Member
|
Thank you for the contribution! |
Sorry, something went wrong.
elan-ajain
pushed a commit
to elancapital/pythonnet
that referenced
this pull request
Feb 17, 2023
* 1783 Implement Interface And Inherit Class Added support for multiple inheritance when inheriting from one base class and/or multiple interfaces. Added a unit test verifying that it works with a simple class and interface. This unit test would previously have failed since multiple types are in the class super class list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Added support for multiple inheritance when inheriting from one base class and/or multiple interfaces.
Added a unit test verifying that it works with a simple class and interface. This unit test would previously have failed since multiple types are in the class super class list.
Close #1783
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG