◐ Shell
reader mode source ↗
Skip to content
This repository was archived by the owner on Jan 14, 2023. It is now read-only.

Test fixed size arrays#67

Merged
ernestmc merged 4 commits into
rosjava:kineticfrom
ernestmc:test_fixed_size_arrays
Apr 16, 2018
Merged

Test fixed size arrays#67
ernestmc merged 4 commits into
rosjava:kineticfrom
ernestmc:test_fixed_size_arrays

Conversation

@ernestmc

@ernestmc ernestmc commented Apr 11, 2018

Copy link
Copy Markdown
Member

Adds unit test cases for fixed sized arrays with different data types.
Note that currently some tests are not passing and will be addressed in future pull requests like #59 which is pending review.

To run the tests:

./gradlew test

Here's a snapshot of the current status of the tests:

image

@ernestmc ernestmc requested a review from jubeira April 11, 2018 17:12

@jubeira jubeira left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for the contribution!

I only have one comment regarding this. I think this is good to have even if not all the tests are passing; we can fix them in future PRs.

@jubeira

jubeira commented Apr 16, 2018

Copy link
Copy Markdown

Thanks @ernestmc; you already have my approval :)

@ernestmc ernestmc merged commit b9a9858 into rosjava:kinetic Apr 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants