respect read-only source space#37
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Sorry, something went wrong.
|
CLA done |
Sorry, something went wrong.
|
CLAs look good, thanks! |
Sorry, something went wrong.
|
Thanks for the submission @fmessmer; I'll give it a shot. Could you explain a bit more the problem you addressed? Did the CI fail because the source space was not read-only? |
Sorry, something went wrong.
|
CI failed because source space is read-only |
Sorry, something went wrong.
|
@fmessmer I see your point; the only thing that makes me a bit unsure about this is that building projects with Gradle wrapper ( On the other hand, I talked with @ernestmc and he tends to agree with using the build space to dump the results as you propose. The motivation is that it's OK for catkin to behave the same for anything it's building, so there should be no difference between building a Gradle project or a python / C++ package. I'll leave this open just a bit more; if there are no comments against it I will merge it after some tests. |
Sorry, something went wrong.
…OSITORY preserve ROS_MAVEN_DEPLOYMENT_REPOSITORY if already set and part of w…
by executing the custom_targets in the build space rather than source space
read-only source space is enforced by e.g. https://github.com/ros-industrial/industrial_ci