{{ message }}
Skip FileListPreprocessor for autofill=false parameters #423
Open
imagejan wants to merge 1 commit into
Open
Conversation
Member
Sorry, something went wrong.
This commit changes the API of ModuleService and DefaultModuleService to include an optional parameter 'acrossTypes' that allows checking for solitary unresolved parameters within all inputs/outputs independent of their type, while maintaining the backwards compatible method signatures. We can then replace some duplicated logic in helper methods of FilePreprocessor and FileListPreprocessor by a call to 'moduleService.getSingleInput()', which makes them respect an 'autoFill=false' parameter annotation and avoid calling uiService.chooseFile/chooseFiles for those parameters. The intended behavior is verified by two new tests that, before this commit, are failing on their last assertion.
imagejan
force-pushed
the
fix-filelistpreprocessor-autofill-false
branch
from
2aa1968 to
4168b3e
Compare
May 16, 2021 18:13
imagejan
commented
May 16, 2021
Member
|
Sorry it's taken me so long to look at this. I now have a dedicated PR review day per week, and this one is on my shortlist right now to review, but I'm trying to apply the 80/20 rule to do the easiest ones first. My hangup on this one is the addition of the |
Sorry, something went wrong.
ctrueden
force-pushed
the
master
branch
3 times, most recently
from
53b6733 to
3dc99c9
Compare
November 7, 2023 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This pull request is a work in progress.This pull request changes the API of
ModuleServiceandDefaultModuleServiceto include an optional parameterboolean acrossTypesthat allows checking for solitary unresolved parameters within all inputs/outputs independent of their type, while maintaining the backwards-compatible method signatures.This allows to replace some duplicated logic in helper methods of
FilePreprocessorandFileListPreprocessorby a call tomoduleService.getSingleInput(), which makes them respect anautoFill=falseparameter annotation and avoid callinguiService.chooseFile/chooseFilesfor those parameters.The intended behavior is verified by two new tests that, before this PR, were failing on their last assertion.
NB: The tests added here call
uiService.setHeadless(false)in order to set their custom default UI.